Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tool templates for COSMOS 6 #1747

Merged
merged 9 commits into from
Dec 16, 2024
Merged

Update tool templates for COSMOS 6 #1747

merged 9 commits into from
Dec 16, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Dec 9, 2024

closes #1743

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (b9f637e) to head (b055e63).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1747   +/-   ##
=======================================
  Coverage   79.57%   79.58%           
=======================================
  Files         517      517           
  Lines       40736    40736           
=======================================
+ Hits        32416    32419    +3     
+ Misses       8320     8317    -3     
Flag Coverage Δ
python 84.30% <ø> (+0.02%) ⬆️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryan-pratt ryan-pratt requested a review from ryanmelt December 10, 2024 23:34
@ryan-pratt
Copy link
Contributor

Just pushed a commit here to update the rest of the templates, but they need to be checked by someone else due to the yarn link issues we're discussing offline

@jmthomas jmthomas marked this pull request as ready for review December 11, 2024 21:15
The CdkPortal thing isn't getting style and the file menu isn't
visible... this seems unrelated to the COSMOS 6 stuff?
@ryan-pratt ryan-pratt changed the title Working tool_vue template Update tool templates for COSMOS 6 Dec 12, 2024
@ryan-pratt
Copy link
Contributor

Current status: everything is done except tool_angular isn't applying styles to the menu stuff through CdkPortal, so the "File" button is just text and the menu itself is hidden when it opens

@ryanmelt ryanmelt merged commit 5ff0cb2 into main Dec 16, 2024
28 checks passed
@ryanmelt ryanmelt deleted the templates branch December 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Tool Templates (Vue, React, Angular, Svelte) for COSMOS 6
3 participants