Skip to content

Commit

Permalink
Remove template updates from package_audit
Browse files Browse the repository at this point in the history
  • Loading branch information
@ryan-pratt
ryan-pratt committed Dec 12, 2024
1 parent 17e63e0 commit c702091
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions scripts/release/package_audit.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,15 @@

puts "\n\nRun the following:"
puts "cd openc3-cosmos-init/plugins; yarn install; yarn upgrade-interactive --latest; cd ../.."
puts "cd openc3/templates/widget; yarn install; yarn upgrade-interactive --latest; cd ../../.."
puts "cd openc3/templates/tool_vue; yarn install; yarn upgrade-interactive --latest; cd ../../.."
puts "cd openc3/templates/tool_react; yarn install; yarn upgrade-interactive --latest; cd ../../.."
puts "cd openc3/templates/tool_angular; yarn install; yarn upgrade-interactive --latest; cd ../../.."
puts "cd openc3/templates/tool_svelte; yarn install; yarn upgrade-interactive --latest; cd ../../.."
puts "cd playwright; yarn install; yarn upgrade-interactive --latest; cd .."
puts "cd docs.openc3.com; yarn install; yarn upgrade-interactive --latest; cd .."

# Commenting this out since the templates don't really need to be updated, and updates broke them over time
# puts "\n\nYou can run the following, but check that the templates still work if you do:"
# puts "cd openc3/templates/widget; yarn install; yarn upgrade-interactive --latest; cd ../../.."
# puts "cd openc3/templates/tool_vue; yarn install; yarn upgrade-interactive --latest; cd ../../.."
# puts "cd openc3/templates/tool_react; yarn install; yarn upgrade-interactive --latest; cd ../../.."
# puts "cd openc3/templates/tool_angular; yarn install; yarn upgrade-interactive --latest; cd ../../.."
# puts "cd openc3/templates/tool_svelte; yarn install; yarn upgrade-interactive --latest; cd ../../.."

puts "\n\n*** If you update #{base_pkgs.join(', ')} then re-run! ***\n\n"

1 comment on commit c702091

@ryanmelt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand not wanting to break the templates, but we need to keep them security patched as well. Rather than fixed versions in the templates could we change to more fuzzy versioning to allow for automatic security patching within a version chain?

Please sign in to comment.