Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytical Advection in jit #1612

Draft
wants to merge 59 commits into
base: master
Choose a base branch
from
Draft

Analytical Advection in jit #1612

wants to merge 59 commits into from

Commits on Jul 16, 2024

  1. First attempt to create header-file for analytical advection in JIT

    @erikvansebille
    erikvansebille committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    91fb4e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. First semi-complete C-version of analytical-advection (not working)

    @erikvansebille
    erikvansebille committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    90e1190 View commit details
    Browse the repository at this point in the history

  2. Fixing customed_Cfunc_header_test to use particle_dlon

    @erikvansebille
    erikvansebille committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    81d7c1d View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Fixing small but important bug in advection computation

    @erikvansebille
    erikvansebille committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    314493a View commit details
    Browse the repository at this point in the history

  2. Using functions for computing ds and rs

    @erikvansebille
    erikvansebille committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    760fe58 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Adding support for dt<0

    @erikvansebille
    erikvansebille committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f48d052 View commit details
    Browse the repository at this point in the history

  2. Adding 3D support to analyticaladvection

    @erikvansebille
    erikvansebille committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6e96fe3 View commit details
    Browse the repository at this point in the history

  3. renaming xgrid_loc, ygrid_loc to px, py

    @erikvansebille
    erikvansebille committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    ebd11cb View commit details
    Browse the repository at this point in the history

  4. Automatic loading of library when calling AdvectionAnalytical in JIT

    @erikvansebille
    erikvansebille committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2a67fd1 View commit details
    Browse the repository at this point in the history

  5. Updating function names for future support of 2D

    @erikvansebille
    erikvansebille committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    beb1a0a View commit details
    Browse the repository at this point in the history

  6. Implementing separate 2D kernel for JIT AnalyticalAdvection

    @erikvansebille
    erikvansebille committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    eed3422 View commit details
    Browse the repository at this point in the history

  7. Support for 2D JIT AnalyticalAdvection in kernel.py

    @erikvansebille
    erikvansebille committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1fb9de2 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into analyticaladvection_in_jit

    @erikvansebille
    erikvansebille committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    bfab79c View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. FIxing timevarying flow in 2D mode

    @erikvansebille
    erikvansebille committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cd325b8 View commit details
    Browse the repository at this point in the history

  2. Setting include_dirs to inlcude application_kernels

    @erikvansebille
    erikvansebille committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5c03327 View commit details
    Browse the repository at this point in the history

  3. Fixing 2D analyticaladvection to work with and without time

    @erikvansebille
    erikvansebille committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1f56ec9 View commit details
    Browse the repository at this point in the history

  4. Adding particle.ti as function input

    @erikvansebille
    erikvansebille committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    acba3fd View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Fixing xi sampling code, and making unit test more subtle

    @erikvansebille
    erikvansebille committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    47f50a0 View commit details
    Browse the repository at this point in the history

  2. Fixing calling analyticaladvection with general particle.xi

    @erikvansebille
    erikvansebille committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d2c27f3 View commit details
    Browse the repository at this point in the history

  3. Fixing small bug in jit analyticaladvection

    @erikvansebille
    erikvansebille committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c769886 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Fixing AnalyticalAdvection Kernels to also work well for negative speeds

    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    2bc9af3 View commit details
    Browse the repository at this point in the history

  2. Combining AnalyticalAdvection in 2D and 3D JIT into one C function

    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    74b0d83 View commit details
    Browse the repository at this point in the history

  3. Using particle_ddepth in analyticaladvection

    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0edacc5 View commit details
    Browse the repository at this point in the history

  4. FIxing Scipy AnalyticalAdvection to add to dlon,dlat,ddepth instead o… 

    …f overwrite
    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ff57384 View commit details
    Browse the repository at this point in the history

  5. Updating AnalyticalAdvection tutorial

    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d4c9a6a View commit details
    Browse the repository at this point in the history

  6. Fixing include statement in codegenerator

    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    96e6176 View commit details
    Browse the repository at this point in the history

  7. Support for Curvilinear Grids in AnalyticalAdvection

    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ae9f681 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into analyticaladvection_in_jit

    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b2406fe View commit details
    Browse the repository at this point in the history

  9. Updating to change GridCode -> GridType 

    As per #1615
    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    116416b View commit details
    Browse the repository at this point in the history

  10. Generalising gridindexingtype for AnalyticalAdvection in JIT

    @erikvansebille
    erikvansebille committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1fcf875 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Also writing first time of simulation in AnalyticalAdvection

    @erikvansebille
    erikvansebille committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2863265 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into analyticaladvection_in_jit

    @erikvansebille
    erikvansebille committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c297795 View commit details
    Browse the repository at this point in the history

  3. Moving c1,c2,c3,c4 calculation outside flow3D if-loop

    @erikvansebille
    erikvansebille committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    3913277 View commit details
    Browse the repository at this point in the history

  4. Changing gcode -> gtype in advectionanalytical.h

    @erikvansebille
    erikvansebille committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    46b9675 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. setting counter inside for-loop for reduced clutter

    @erikvansebille
    erikvansebille committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    abbf683 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Fixing bug in backward AnalyticalAdvection where wrong cell was used

    @erikvansebille
    erikvansebille committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6203413 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Fixing grid search bug, and increasing tolerance for grid search

    @erikvansebille
    erikvansebille committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e24041f View commit details
    Browse the repository at this point in the history

  2. Finding correct cell for analyticaladvection in a loop

    @erikvansebille
    erikvansebille committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    c28a4df View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Adding support for time-evolving fields in cell search

    @erikvansebille
    erikvansebille committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8f34f69 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into analyticaladvection_in_jit

    @erikvansebille
    erikvansebille committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2f4cae3 View commit details
    Browse the repository at this point in the history

  3. Update tutorial_advection to new parcels import

    @erikvansebille
    erikvansebille committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    317172c View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Merge branch 'master' into analyticaladvection_in_jit

    @VeckoTheGecko
    VeckoTheGecko committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6bbbe70 View commit details
    Browse the repository at this point in the history

  2. Add noqa flags

    @VeckoTheGecko
    VeckoTheGecko committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0a98f39 View commit details
    Browse the repository at this point in the history

  3. Using NEMO cell edges (e1v, e2u etc) in calculation of fluxes 

    This hugely improves the accuracy in e.g. a fwd-bwd run of the NEMO Gulf Stream simulation

This needs to be coded much cleaner still
    @erikvansebille
    erikvansebille committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    99d94b2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into analyticaladvection_in_jit

    @erikvansebille
    erikvansebille committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    405cc6d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'analyticaladvection_in_jit' of https://github.com/Ocean… 

    …Parcels/parcels into analyticaladvection_in_jit
    @erikvansebille
    erikvansebille committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    c5fe559 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Fixing analyticaladvection to expect grid sizes in Nemo format

    @erikvansebille
    erikvansebille committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c025d94 View commit details
    Browse the repository at this point in the history

  2. Updating test_advection to use nemo gridsizes for AA

    @erikvansebille
    erikvansebille committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2ea2c73 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into analyticaladvection_in_jit

    @erikvansebille
    erikvansebille committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    af46e0e View commit details
    Browse the repository at this point in the history

  4. Adding comment to also update Scipy AA code

    @erikvansebille
    erikvansebille committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a1750d5 View commit details
    Browse the repository at this point in the history

  5. Fixing outofbounds test for flow3D == 0

    @erikvansebille
    erikvansebille committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f5c0e95 View commit details
    Browse the repository at this point in the history

  6. Updating analyticaladvection tutorial to use Nemo cell edge convention

    @erikvansebille
    erikvansebille committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4505636 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Adding mesh_mask_edges file for AA in nemo_curvilinear

    @erikvansebille
    erikvansebille committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f557e3c View commit details
    Browse the repository at this point in the history

  2. Updating mesh_mask_edges filename

    @erikvansebille
    erikvansebille committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    71eb3f7 View commit details
    Browse the repository at this point in the history

  3. Adding cell edges to AnalyticalAdvection in example_peninsula

    @erikvansebille
    erikvansebille committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fd7383f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Merge branch 'master' into analyticaladvection_in_jit

    @erikvansebille
    erikvansebille committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f0974d4 View commit details
    Browse the repository at this point in the history

  2. Changing time interpolation scheme to use intermediate timesteps better

    @erikvansebille
    erikvansebille committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c98161e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'analyticaladvection_in_jit' of https://github.com/Ocean… 

    …Parcels/parcels into analyticaladvection_in_jit
    @erikvansebille
    erikvansebille committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    adce434 View commit details
    Browse the repository at this point in the history

  4. Renaming direction to time_direction throughout

    @erikvansebille
    erikvansebille committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4578997 View commit details
    Browse the repository at this point in the history