-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations-shopify-scim): shopify SCIM provider #3278
base: master
Are you sure you want to change the base?
Changes from 3 commits
7cf2d43
124f69c
e5a4350
4912534
b6d2b1a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6287,6 +6287,26 @@ shopify: | |
suffix: .myshopify.com | ||
prefix: https:// | ||
|
||
shopify-scim: | ||
display_name: Shopify (SCIM API) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing the connection docs link and the link to the specific step. See https://github.com/NangoHQ/nango/blob/master/packages/shared/providers.yaml#L235 and https://github.com/NangoHQ/nango/blob/master/packages/shared/providers.yaml#L244 |
||
categories: | ||
- e-commerce | ||
auth_mode: API_KEY | ||
proxy: | ||
base_url: https://shopifyscim.com/scim/v2 | ||
headers: | ||
authorization: Bearer ${apiKey} | ||
accept: application/json | ||
content-type: application/json | ||
retry: | ||
after: 'retry-after' | ||
docs: https://docs.nango.dev/integrations/all/shopify | ||
credentials: | ||
apiKey: | ||
type: string | ||
title: SCIM API Token | ||
description: The SCIM API token generated from your Shopify organization settings. | ||
|
||
shortcut: | ||
display_name: Shortcut | ||
categories: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
shopify.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing that I missed from before. At the bottom of this file should be a reference to the connect docs as seen here https://github.com/NangoHQ/nango/blob/master/docs-v2/integrations/all/algolia.mdx#going-further
It should say specifically Shopify SCIM similar to https://github.com/NangoHQ/nango/blob/master/docs-v2/integrations/all/trello.mdx