feat(integrations-shopify-scim): shopify SCIM provider #3278
+93
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
approved these changes
Jan 9, 2025
khaliqgant
reviewed
Jan 10, 2025
| @@ -6287,6 +6287,26 @@ shopify: | |||
| suffix: .myshopify.com | |||
| prefix: https:// | |||
|
|
|||
| shopify-scim: | |||
| display_name: Shopify (SCIM API) | |||
There was a problem hiding this comment.
Missing the connection docs link and the link to the specific step. See https://github.com/NangoHQ/nango/blob/master/packages/shared/providers.yaml#L235 and https://github.com/NangoHQ/nango/blob/master/packages/shared/providers.yaml#L244
khaliqgant
requested changes
Jan 10, 2025
khaliqgant
reviewed
Jan 11, 2025
| @@ -40,6 +40,7 @@ _No setup guide yet._ | |||
| - [OAuth-related docs](https://shopify.dev/docs/apps/auth/oauth) | |||
| - [List of OAuth scopes](https://shopify.dev/docs/api/usage/access-scopes#authenticated-access-scopes) | |||
| - [API](https://shopify.dev/docs/api/admin) | |||
| - [SCIM API Docs](https://help.shopify.com/en/manual/organization-settings/users/security/scim) | |||
There was a problem hiding this comment.
Last thing that I missed from before. At the bottom of this file should be a reference to the connect docs as seen here https://github.com/NangoHQ/nango/blob/master/docs-v2/integrations/all/algolia.mdx#going-further
It should say specifically Shopify SCIM similar to https://github.com/NangoHQ/nango/blob/master/docs-v2/integrations/all/trello.mdx
khaliqgant
requested changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created shopify SCIM provider. For the docs, I might need to have a paid account to clearly and concisely write the documentation
[297] https://linear.app/nango/issue/EXT-297/shopify-user-provisioning