Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow matmul heuristic plugin to set cluster dimensions #3634

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Allow matmul heuristic plugin to set cluster dimensions #3634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions csrc/scheduler/matmul_heuristic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ class MatmulParams : public HeuristicParams {
: "column-major")
<< "\n"
<< "Grid swizzle factor: " << grid_swizzle_factor << "\n"
<< "Cluster dimensions: " << std::get<0>(cluster_dims) << " "
<< std::get<1>(cluster_dims) << " " << std::get<2>(cluster_dims) << "\n"
<< "Use shared memory epilogue: " << use_smem_epilogue << "\n"
<< "Promote re-use of prologue shared memory: "
<< promote_prologue_smem_reuse << "\n"
Expand Down
6 changes: 6 additions & 0 deletions csrc/scheduler/matmul_heuristic_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ void copyParamsToConfig(KernelConfig* config, const MatmulParams* mparams) {
setConfigTile(config->cta_tile, mparams->tile_sizes.cta_tile);
setConfigTile(config->warp_tile, mparams->tile_sizes.warp_tile);
setConfigTile(config->instruction_tile, getMmaOpShape(mparams->mma_macro));
config->cluster_dims[0] = std::get<0>(mparams->cluster_dims);
config->cluster_dims[1] = std::get<1>(mparams->cluster_dims);
config->cluster_dims[2] = std::get<2>(mparams->cluster_dims);
config->splitk_factor = mparams->splitk_factor;
config->grid_swizzle_factor = mparams->grid_swizzle_factor;
config->cta_order =
Expand All @@ -163,6 +166,9 @@ void copyConfigToParams(MatmulParams* mparams, const KernelConfig* config) {
};
setGemmTile(mparams->tile_sizes.cta_tile, config->cta_tile);
setGemmTile(mparams->tile_sizes.warp_tile, config->warp_tile);
std::get<0>(mparams->cluster_dims) = config->cluster_dims[0];
std::get<1>(mparams->cluster_dims) = config->cluster_dims[1];
std::get<2>(mparams->cluster_dims) = config->cluster_dims[2];
mparams->circular_buffer_options.smem_circular_buffer_stage =
config->load_stages;
mparams->circular_buffer_options.smem_circular_buffer_prefetch_gap =
Expand Down
1 change: 1 addition & 0 deletions csrc/scheduler/matmul_heuristic_plugin_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ struct KernelConfig {
Tile cta_tile = {128, 128, 32};
Tile warp_tile = {64, 64, 32};
Tile instruction_tile = {16, 16, 16};
Tile cluster_dims = {1, 1, 1};
uint16_t splitk_factor = 1;
uint8_t load_stages = 2;
// The circular buffering prefetch distance will be set to
Expand Down
Loading