Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model EV Batteries #1533

Draft
wants to merge 76 commits into
base: master
Choose a base branch
from
Draft

Model EV Batteries #1533

wants to merge 76 commits into from

Commits on Oct 27, 2023

  1. new arguments and method to write EV battery to xml

    @aspeake
    aspeake committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    7b651b0 View commit details
    Browse the repository at this point in the history

  2. custom schedule columns for EV batteries

    @aspeake
    aspeake committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    36492fb View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. fix ev battery schedule generation, generalize for ev and non-ev batt… 

    …ery schedules
    @aspeake
    aspeake committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    08c8c5a View commit details
    Browse the repository at this point in the history

  2. allow one EV and one non-EV battery in schema

    @aspeake
    aspeake committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3f94374 View commit details
    Browse the repository at this point in the history

  3. stub out defaults for EV batteries

    @aspeake
    aspeake committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    744ad66 View commit details
    Browse the repository at this point in the history

  4. update how battery ids are assigned in xml

    @aspeake
    aspeake committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    4f1a37e View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. make ev_battery_preset argument optional

    @aspeake
    aspeake committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    210c463 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int… 

    …o ev_batteries

# Conflicts:
#	BuildResidentialHPXML/measure.rb
#	HPXMLtoOpenStudio/resources/battery.rb
#	HPXMLtoOpenStudio/resources/hpxml_defaults.rb
    @shorowit
    shorowit committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5c36fcb View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. always require schedule when modeling ev batteries

    @aspeake
    aspeake committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    01437d0 View commit details
    Browse the repository at this point in the history

  2. initial tests for ev batteries

    @aspeake
    aspeake committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8f33e3d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    52bc3ab View commit details
    Browse the repository at this point in the history

  4. add missing ev battery schedule for tests

    @aspeake
    aspeake committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9db3aeb View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. update log message tests for batteries

    @aspeake
    aspeake committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    da8dc17 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    357ba18 View commit details
    Browse the repository at this point in the history

  3. fix test for battery log message

    @aspeake
    aspeake committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    374aae8 View commit details
    Browse the repository at this point in the history

  4. Latest results.

    GitHub Action committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    2a9b7bb View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    dd4d5cf View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Seperate EVs from batteries and leverage existing EV charger fields

    @aspeake
    aspeake committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    61d39b6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    22f00b2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML… 

    … into ev_batteries
    @aspeake
    aspeake committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0056e2c View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Refine inputs for EV battery and charger, update tests

    @aspeake
    aspeake committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    f6b88a3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    1effbc8 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. update unit tests for EVs and chargers; apply rubocop

    @aspeake
    aspeake committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6fbd4f5 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bd3fbfe View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. fix failing tests for ev batteries

    @aspeake
    aspeake committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    35e8be4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    cefa4e2 View commit details
    Browse the repository at this point in the history

  3. Latest results.

    GitHub Action committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e279ea4 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b86a506 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML… 

    … into ev_batteries
    @aspeake
    aspeake committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3228c7a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Update EV arguments for latest approach to argument handling

    @aspeake
    aspeake committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    5d21e32 View commit details
    Browse the repository at this point in the history

  2. Generate an ELCD object for each EV battery

    @aspeake
    aspeake committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b1ef026 View commit details
    Browse the repository at this point in the history

  3. Update reporting measure to output EV energy

    @aspeake
    aspeake committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    a413534 View commit details
    Browse the repository at this point in the history

  4. EMS program to adjust effective EV discharge power and offset that di… 

    …scharge power for reporting
    @aspeake
    aspeake committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    2432bfb View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9c31908 View commit details
    Browse the repository at this point in the history

  2. Pull in latest Vehicles changes in HPXML schema, update HPXML classes… 

    … as needed; expose fuel economy and vehicle miles traveled args
    @aspeake
    aspeake committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    0c8861c View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Introduce miles/yr and hours/wk arguments for EVs, calculate the effe… 

    …ctive discharge power
    @aspeake
    aspeake committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    891f609 View commit details
    Browse the repository at this point in the history

  2. Write EV fraction charged at home to HPXML

    @aspeake
    aspeake committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3291f9c View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Fix for EV discharge offset object when EV location is garage

    @aspeake
    aspeake committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2bfc0f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Fix bug iniitalizing DBT sensor

    @aspeake
    aspeake committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b2d226a View commit details
    Browse the repository at this point in the history

  2. Apply rubocop

    @aspeake
    aspeake committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d0a554f View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ea3d06f View commit details
    Browse the repository at this point in the history

  2. Pull in latest HPXML schema for EVs

    @aspeake
    aspeake committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    7d04943 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Fix merge conflict

    @aspeake
    aspeake committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a5a3fc7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    d591cad View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Fix unit tests for EV batteries

    @aspeake
    aspeake committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    52d07dd View commit details
    Browse the repository at this point in the history

  2. update in-line documentation for vehicles and batteries

    @aspeake
    aspeake committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    aaecf51 View commit details
    Browse the repository at this point in the history

  3. address unit test failures for EV batteries

    @aspeake
    aspeake committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    14f026e View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ed8cc5b View commit details
    Browse the repository at this point in the history

  5. fixes for timeseries tests of EVs

    @aspeake
    aspeake committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    357509e View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Latest results.

    GitHub Action committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    1e89f06 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. prevent EVs modeled with a plug load and a battery at the same time

    @aspeake
    aspeake committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    50a8c47 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML… 

    … into ev_batteries
    @aspeake
    aspeake committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8cc6c93 View commit details
    Browse the repository at this point in the history

  3. pull in latest HPXML schema

    @aspeake
    aspeake committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1198abd View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int… 

    …o ev_batteries

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.rb
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/battery.rb
#	HPXMLtoOpenStudio/resources/data/unavailable_periods.csv
#	HPXMLtoOpenStudio/resources/defaults.rb
#	HPXMLtoOpenStudio/resources/hpxml_schema/HPXML.xsd
#	HPXMLtoOpenStudio/resources/schedules.rb
#	ReportSimulationOutput/measure.xml
#	workflow/tests/base_results/results_simulations_energy.csv
    @shorowit
    shorowit committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9c373df View commit details
    Browse the repository at this point in the history

  2. Bugfix.

    @shorowit
    shorowit committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    cbc7fa1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. discard EMS for offsetting EV discharge energy and handle it directly… 

    … in the reporting measure
    @aspeake
    aspeake committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    59d5594 View commit details
    Browse the repository at this point in the history

  2. new reporting measure class to output vehicle-specific variables that… 

    … are not end-uses; move discharging energy from end-uses to this class
    @aspeake
    aspeake committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    385c67b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    486f01f View commit details
    Browse the repository at this point in the history

  4. apply RuboCop

    @aspeake
    aspeake committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    32e567b View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. fix bug for vehicles in the reporting measures

    @aspeake
    aspeake committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    28e1849 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Include reporting measure arguments to trigger vehicle outputs

    @aspeake
    aspeake committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d17000e View commit details
    Browse the repository at this point in the history

  2. Latest results.

    GitHub Action committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    18bf8fc View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. refrain from using object id to check if a battery is for a vehicle

    @aspeake
    aspeake committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    14718f5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML… 

    … into ev_batteries
    @aspeake
    aspeake committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e032b3e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. simplify access to vehicle objects when applying to model; some cleanup

    @aspeake
    aspeake committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    962797a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5d21764 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge branch 'master' into ev_batteries

    @rajeee
    rajeee committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d7e8f28 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Default schedules for EV batteries and EV plug loads

    @aspeake
    aspeake committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5101e71 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML… 

    … into ev_batteries
    @aspeake
    aspeake committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7452d70 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    67401df View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Pull in latest HPXML schema changes to vehicles

    @aspeake
    aspeake committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    532abc2 View commit details
    Browse the repository at this point in the history

  2. Account for vehicles specified as EV batteries and as plug loads

    @aspeake
    aspeake committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ff17916 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Merge remote-tracking branch 'origin/master' into ev_batteries

    @aspeake
    aspeake committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    caf8114 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. New EMS variable to track unmet driving hours, report with Vehicle Ty… 

    …pe outputs.
    @aspeake
    aspeake committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8b29eab View commit details
    Browse the repository at this point in the history

  2. Add check to avoid always trying to report unmet driving hours

    @aspeake
    aspeake committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d0bbdd4 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Always load EV discharge energy variable to adjust electricity meter.

    @aspeake
    aspeake committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5d3eeae View commit details
    Browse the repository at this point in the history