Model EV Batteries #1533

aspeake · 2023-10-30T23:15:48Z

Pull Request Description

Allows a new battery object specific to EVs. Implemented in a way such that it could eventually support bidirectional charging, but not included in this PR.

Companion HPXML PR: hpxmlwg/hpxml#403

Checklist

PR Author: Check these when they're done. Not all may apply. ~~strikethrough~~ and check any that do not apply.

PR Reviewer: Verify each has been completed.

Schematron validator (EPvalidator.xml) has been updated
Sample files have been added/updated (via tasks.rb)
Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
Documentation has been updated
Changelog has been updated
openstudio tasks.rb update_measures has been run
No unexpected changes to simulation results of sample files

…ery schedules

…o ev_batteries # Conflicts: # BuildResidentialHPXML/measure.rb # HPXMLtoOpenStudio/resources/battery.rb # HPXMLtoOpenStudio/resources/hpxml_defaults.rb

… into ev_batteries

shorowit · 2024-01-23T19:01:32Z

@aspeake I assume we will need to add error-checking for multiple batteries? I.e., you can't have two EV batteries, and you can't have one EV battery and one home battery. See here for context. Unless you are trying to address this limitation.

aspeake · 2024-01-23T20:46:37Z

@aspeake I assume we will need to add error-checking for multiple batteries? I.e., you can't have two EV batteries, and you can't have one EV battery and one home battery. See here for context. Unless you are trying to address this limitation.

Yes, for now we plan to limit to 1 EV/unit. However, the current implementation does allow for one home battery and one EV battery and expects separate schedules for each.

shorowit · 2024-01-23T21:27:27Z

However, the current implementation does allow for one home battery and one EV battery and expects separate schedules for each.

I assume that probably won't work, for the same reason that modeling two home batteries wasn't previously supported. But we can worry about that later. More of a heads up for now.

shorowit · 2024-10-15T17:46:36Z

Possibility for upcoming release. I will pull in master and resolve conflicts. Need to allow a simple (smooth) schedule default. It should already be working w/ power outages and vacancies.

…o ev_batteries # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.rb # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/battery.rb # HPXMLtoOpenStudio/resources/data/unavailable_periods.csv # HPXMLtoOpenStudio/resources/defaults.rb # HPXMLtoOpenStudio/resources/hpxml_schema/HPXML.xsd # HPXMLtoOpenStudio/resources/schedules.rb # ReportSimulationOutput/measure.xml # workflow/tests/base_results/results_simulations_energy.csv

shorowit

This was not a thorough review, just some random things I saw while pulling in master and resolving conflicts.

BuildResidentialHPXML/measure.rb

BuildResidentialHPXML/tests/test_build_residential_hpxml.rb

HPXMLtoOpenStudio/resources/battery.rb

HPXMLtoOpenStudio/resources/defaults.rb

HPXMLtoOpenStudio/tests/test_battery.rb

ReportSimulationOutput/measure.rb

shorowit · 2024-10-15T22:00:16Z

tasks.rb

+    # HPXML EV Battery #
+    # ---------------- #
+
+    if ['base-battery-ev-lifetime-model.xml'].include? hpxml_file


Surprised to see this. We previously disabled this model for home batteries (as part of this PR). I don't remember why offhand without digging in. Are we sure we want to use/allow it here?

shorowit · 2024-10-15T22:00:43Z

ReportSimulationOutput/measure.rb

          next unless subcategory.start_with? obj_name
          fail 'Unepected error: multiple matches.' unless end_use.nil?

+          ### FIXME: ensure loss program applies to the correct battery


Need to address?

shorowit · 2024-10-15T22:01:24Z

HPXMLtoOpenStudio/tests/test_vehicle.rb

+  def test_ev_battery_home_battery
+    # TO-DO: test two batteries, one EV, one home
+  end
+
+  def test_ev_battery_scheduled_default
+    # TO-DO: test ev battery with schedule (so it is modeled) but with all other fields defaulted
+  end


HPXMLtoOpenStudio/resources/vehicle.rb

… in the reporting measure

… are not end-uses; move discharging energy from end-uses to this class

… into ev_batteries

…pe outputs.

aspeake added 7 commits October 27, 2023 16:49

new arguments and method to write EV battery to xml

7b651b0

custom schedule columns for EV batteries

36492fb

fix ev battery schedule generation, generalize for ev and non-ev batt…

08c8c5a

…ery schedules

allow one EV and one non-EV battery in schema

3f94374

stub out defaults for EV batteries

744ad66

update how battery ids are assigned in xml

4f1a37e

make ev_battery_preset argument optional

210c463

shorowit assigned aspeake Oct 31, 2023

shorowit added the enhancement New feature or request label Oct 31, 2023

shorowit and others added 13 commits November 2, 2023 08:57

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

5c36fcb

…o ev_batteries # Conflicts: # BuildResidentialHPXML/measure.rb # HPXMLtoOpenStudio/resources/battery.rb # HPXMLtoOpenStudio/resources/hpxml_defaults.rb

always require schedule when modeling ev batteries

01437d0

initial tests for ev batteries

8f33e3d

Merge remote-tracking branch 'origin/master' into ev_batteries

52bc3ab

add missing ev battery schedule for tests

9db3aeb

update log message tests for batteries

da8dc17

Merge remote-tracking branch 'origin/master' into ev_batteries

357ba18

fix test for battery log message

374aae8

Latest results.

2a9b7bb

Merge remote-tracking branch 'origin/master' into ev_batteries

dd4d5cf

Seperate EVs from batteries and leverage existing EV charger fields

61d39b6

Merge remote-tracking branch 'origin/master' into ev_batteries

22f00b2

Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML…

0056e2c

… into ev_batteries

aspeake added 5 commits February 5, 2024 12:52

Refine inputs for EV battery and charger, update tests

f6b88a3

Merge remote-tracking branch 'origin/master' into ev_batteries

1effbc8

update unit tests for EVs and chargers; apply rubocop

6fbd4f5

Merge remote-tracking branch 'origin/master' into ev_batteries

bd3fbfe

fix failing tests for ev batteries

35e8be4

shorowit reviewed Oct 15, 2024

View reviewed changes

Bugfix.

cbc7fa1

shorowit reviewed Oct 15, 2024

View reviewed changes

HPXMLtoOpenStudio/resources/vehicle.rb Outdated Show resolved Hide resolved

aspeake added 4 commits October 16, 2024 20:29

discard EMS for offsetting EV discharge energy and handle it directly…

59d5594

… in the reporting measure

new reporting measure class to output vehicle-specific variables that…

385c67b

… are not end-uses; move discharging energy from end-uses to this class

Merge remote-tracking branch 'origin/master' into ev_batteries

486f01f

apply RuboCop

32e567b

aspeake force-pushed the ev_batteries branch from e8e14c1 to 7c3a84a Compare October 18, 2024 16:58

fix bug for vehicles in the reporting measures

28e1849

aspeake force-pushed the ev_batteries branch from 7c3a84a to 28e1849 Compare October 18, 2024 17:46

aspeake and others added 6 commits October 21, 2024 13:50

Include reporting measure arguments to trigger vehicle outputs

d17000e

Latest results.

18bf8fc

refrain from using object id to check if a battery is for a vehicle

14718f5

Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML…

e032b3e

… into ev_batteries

simplify access to vehicle objects when applying to model; some cleanup

962797a

Merge remote-tracking branch 'origin/master' into ev_batteries

5d21764

shorowit modified the milestones: 1.9.0, 1.10.0 Oct 29, 2024

rajeee and others added 10 commits October 30, 2024 17:31

Merge branch 'master' into ev_batteries

d7e8f28

Default schedules for EV batteries and EV plug loads

5101e71

Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML…

7452d70

… into ev_batteries

Merge remote-tracking branch 'origin/master' into ev_batteries

67401df

Pull in latest HPXML schema changes to vehicles

532abc2

Account for vehicles specified as EV batteries and as plug loads

ff17916

Merge remote-tracking branch 'origin/master' into ev_batteries

caf8114

New EMS variable to track unmet driving hours, report with Vehicle Ty…

8b29eab

…pe outputs.

Add check to avoid always trying to report unmet driving hours

d0bbdd4

Always load EV discharge energy variable to adjust electricity meter.

5d3eeae

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Model EV Batteries #1533

Model EV Batteries #1533

aspeake commented Oct 30, 2023 •

edited by shorowit

Loading

shorowit commented Jan 23, 2024

aspeake commented Jan 23, 2024

shorowit commented Jan 23, 2024

shorowit commented Oct 15, 2024 •

edited

Loading

shorowit left a comment

shorowit Oct 15, 2024

shorowit Oct 15, 2024

shorowit Oct 15, 2024

Model EV Batteries #1533

Are you sure you want to change the base?

Model EV Batteries #1533

Conversation

aspeake commented Oct 30, 2023 • edited by shorowit Loading

Pull Request Description

Checklist

shorowit commented Jan 23, 2024

aspeake commented Jan 23, 2024

shorowit commented Jan 23, 2024

shorowit commented Oct 15, 2024 • edited Loading

shorowit left a comment

Choose a reason for hiding this comment

shorowit Oct 15, 2024

Choose a reason for hiding this comment

shorowit Oct 15, 2024

Choose a reason for hiding this comment

shorowit Oct 15, 2024

Choose a reason for hiding this comment

aspeake commented Oct 30, 2023 •

edited by shorowit

Loading

shorowit commented Oct 15, 2024 •

edited

Loading