DOI Link Update Check #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slesaad
reviewed
May 9, 2024
pyQuARC/main.py
Outdated
| @@ -188,6 +188,8 @@ def validate(self): | |||
|
|
|||
| @staticmethod | |||
| def _error_message(messages): | |||
| if messages is None: | |||
There was a problem hiding this comment.
why is messages None in the first place? did we check if there was some other issue that's causing "messages" to be None? That should be the first thing you check instead of putting a bandaid here
There was a problem hiding this comment.
I see what the problem is:
In this line,
pyQuARC/pyQuARC/code/url_validator.py
Line 118 in d8c6b5c
value (lowercase v) instead of Value
There was a problem hiding this comment.
okay, thanks. I will look into that.
|
tested? everything working well? |
I tested it on the "echo-c record (C1411142649-LARC)", and everything is working well. |
slesaad
approved these changes
May 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request to solve this issue.
Overview:
In the pyQuarc, while running the collection, it showed the error like this:
Changes made:
Added an if condition to the
_error_messagefunction.Now, above error is not shown.
Tested on echo-c record (C1411142649-LARC) to make sure if it stops quitting the pyQuARC.