Skip to content

[Baldur's Gate 3]: Various bug fixes #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Holt59 merged 6 commits into from
Sep 15, 2025
Merged

[Baldur's Gate 3]: Various bug fixes #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0899e13
Add additional DLLs to the lslib retriever
TheForgotten69 Sep 10, 2025
e007d99
Fix regex pattern for folder name in pak_parser
TheForgotten69 Sep 10, 2025
966aeb6
Ensure log directory is created if missing
TheForgotten69 Sep 10, 2025
48d55aa
Update pak file naming to include parent directory name
TheForgotten69 Sep 10, 2025
7668216
[pre-commit.ci] Auto fixes from pre-commit.com hooks.
pre-commit-ci[bot] Sep 10, 2025
8d8697d
revert change
TheForgotten69 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions games/baldursgate3/lslib_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,12 @@ def _needed_lslib_files(self):
"Divine.dll.config",
"Divine.exe",
"Divine.runtimeconfig.json",
"K4os.Compression.LZ4.dll",
"K4os.Compression.LZ4.Streams.dll",
"LSLib.dll",
"LSLibNative.dll",
"LZ4.dll",
"Newtonsoft.Json.dll",
"System.IO.Hashing.dll",
"ZstdSharp.dll",
}
Expand Down
8 changes: 6 additions & 2 deletions games/baldursgate3/pak_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,11 @@ def _get_metadata_for_file(
f"pak with same name as packable dir exists in mod directory. not packing dir {file}"
)
return ""
pak_path = self._utils.overwrite_path / f"Mods/{file.name}.pak"
parent_mod_name = file.parent.name.replace(" ", "_")
pak_path = (
self._utils.overwrite_path
/ f"Mods/{parent_mod_name}_{file.name}.pak"
)
build_pak = True
if pak_path.exists():
pak_creation_time = os.path.getmtime(pak_path)
Expand Down Expand Up @@ -249,7 +253,7 @@ def metadata_to_ini(
# 2. it has files in Mods/<folder_name>/ other than the meta.lsx file, or
# 3. it has files in Public/<folder_name>
result = self.run_divine(
f'list-package --use-regex -x "(/{folder_name}/(?!meta\\.lsx))|(Public/Engine/Timeline/MaterialGroups)"',
f'list-package --use-regex -x "(/{re.escape(folder_name)}/(?!meta\\.lsx))|(Public/Engine/Timeline/MaterialGroups)"',
file,
)
self._mod_cache[file] = (
Expand Down
1 change: 1 addition & 0 deletions games/game_baldursgate3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ def _base_dlls(self) -> set[str]:
def _on_finished_run(self, exec_path: str, exit_code: int):
if "bin/bg3" not in exec_path:
return
self.utils.log_dir.mkdir(parents=True, exist_ok=True)
if self.utils.log_diff:
for x in difflib.unified_diff(
open(self.utils.modsettings_backup).readlines(),
Expand Down