Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connects to #282. Connects to #284. Data Hub native graphical cluster reports and full PASS1B-06 phenotype table. #283

Merged
merged 26 commits into from
Jan 30, 2024

Conversation

jimmyzhen
Copy link
Contributor

@jimmyzhen jimmyzhen commented Jan 23, 2024

Key Changes:

  1. Converted the large external HTML graphical clustering reports (/graphical-clustering) into something more native to the Data Hub portal with a more integrated look and feel. No longer using iframe to import these HTML files.
    • All expandable/collapsible code blocks have been removed.
    • All interactive pathway enrichment network graphs have been removed.
    • Because all the graphical clustering reports share the same “Introduction” summary, the text has been removed to minimize repetition and rather shown as part of the main page content.
    • Relevant to the mitochondria paper ONLY - the graphical clustering reports are not available for the cortex, hippocampus, hypothalamus and plasma tissue. This is because there are no clustering graphs/plots in their raw HTML reports.
  2. Added new route and component to display the full PASS1B-06 phenotype data table for the phenotype paper submitted at Function.
    • The *.xlsx file containing 4 sheets was converted to Google Sheet. The Google Sheet then was published as non-editable page being loaded into an iframe on Data Hub.
    • The original *.xlsx file can also be downloaded from the page rendered by the component.
  3. Other UI changes:
    • On the Project Overview page (/project-overview), there are now links to animal/human protocols hosted on the main motrpac.org portal. A “Explore data” button has also been added, linking to the differential abundance search page.
    • On the Methods page (/methods), the links to the animal/human protocols have been added to the page summary.

…scape graphical clustering report html files
…eports instead of importing external html pages using iframe

Also moved the common introduction paragraphs from all clustering reports to the page summary
…chondria companion graphical clustering results html files
cteng585
cteng585 previously approved these changes Jan 26, 2024
Copy link
Collaborator

@cteng585 cteng585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working as expected. Graphical clustering feels much better to explore with the changes to how the reports are implemented; I feel that I'm experiencing faster loading times for the page as a whole.

Agreed with Mihir's feedback on the Landscape/Mitochondria toggle. I think my other piece of feedback is that it doesn't feel like "Mitochondria-Related Features Only" needs to be in all-caps. Given that it's a pretty big chunk of text already, making it in uppercase comes across as not trusting the user to understand what the toggle did.

@jimmyzhen
Copy link
Contributor Author

@cteng585 Thanks for the comments.

I've implemented a solution to address the TOC issue described in Mihir's comment, as well as your comment about the ALL CAP title.

I also implemented the additional full phenotype table as mentioned last Friday.

@jimmyzhen jimmyzhen changed the title Connects to #282. Data Hub native graphical cluster reports. Connects to #282. Connects to #284. Data Hub native graphical cluster reports and full PASS1B-06 phenotype table. Jan 29, 2024
@jimmyzhen jimmyzhen merged commit fad0697 into dev Jan 30, 2024
3 checks passed
@jimmyzhen jimmyzhen deleted the 282_JZ_Native_Graphical_Cluster_Reports branch February 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants