-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connects to #282. Connects to #284. Data Hub native graphical cluster reports and full PASS1B-06 phenotype table. #283
Conversation
…scape graphical clustering report html files
…eports instead of importing external html pages using iframe Also moved the common introduction paragraphs from all clustering reports to the page summary
…ape and mito papers
… tissues have no clustering results
…chondria companion graphical clustering results html files
… all child components
…_Native_Graphical_Cluster_Reports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything working as expected. Graphical clustering feels much better to explore with the changes to how the reports are implemented; I feel that I'm experiencing faster loading times for the page as a whole.
Agreed with Mihir's feedback on the Landscape/Mitochondria toggle. I think my other piece of feedback is that it doesn't feel like "Mitochondria-Related Features Only" needs to be in all-caps. Given that it's a pretty big chunk of text already, making it in uppercase comes across as not trusting the user to understand what the toggle did.
…ght for generated toc relative to viewport height
@cteng585 Thanks for the comments. I've implemented a solution to address the TOC issue described in Mihir's comment, as well as your comment about the ALL CAP title. I also implemented the additional full phenotype table as mentioned last Friday. |
Key Changes:
/graphical-clustering
) into something more native to the Data Hub portal with a more integrated look and feel. No longer usingiframe
to import these HTML files.*.xlsx
file containing 4 sheets was converted to Google Sheet. The Google Sheet then was published as non-editable page being loaded into aniframe
on Data Hub.*.xlsx
file can also be downloaded from the page rendered by the component./project-overview
), there are now links to animal/human protocols hosted on the main motrpac.org portal. A “Explore data” button has also been added, linking to the differential abundance search page./methods
), the links to the animal/human protocols have been added to the page summary.