ci: Fix `metamaskbot` comment test build links #29403

Gudahtt · 2024-12-20T18:00:39Z

Description

Various build links in the metamaskbot PR comment were broken. All links have been fixed except beta (which is trickier to fix, requires more substantial changes to the beta workflows, tracked as #29404). The beta link has been removed until we can fix it. Additionally, the Firefox MMI build link has been removed (this build does not work)

Related issues

Fixes: #29402

Manual testing steps

Test that all build links work

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Gudahtt · 2024-12-20T18:11:35Z

.circleci/config.yml

            - prep-build-mmi
            - prep-build-flask
            - prep-build-flask-mv2
+            - prep-build-test


These are all required by the prepublish job because it uses the builds persisted to the workspace by these jobs.

Some of these were indirectly guaranteed to be present in the workspace due to them being required by some other listed dependency here. But best not to rely on that.

Gudahtt · 2024-12-20T18:18:21Z

development/metamaskbot-build-announce.js

-      return `<a href="${url}">${platform}</a>`;
-    })
-    .join(', ');
+  const buildMap = {


Specifying the labels and builds declaratively made it easier to apply the same validation and formatting to all of them.

Gudahtt · 2024-12-20T18:26:17Z

development/metamaskbot-build-announce.js

+      firefox: `${BUILD_LINK_BASE}/builds-mv2/metamask-firefox-${VERSION}.zip`,
+    },
+    'builds (beta)': {
+      chrome: `${BUILD_LINK_BASE}/builds-beta/metamask-flask-chrome-${VERSION}-beta.0.zip`,


This link was updated to be "less wrong" (I added the -beta.0 suffix), but it still won't work for two reasons:

The beta build isn't even generated on most workflows at the moment

Even when it is generated, the number won't always be .0. e.g. it could be beta.1.

To be addressed in the later PR.

Gudahtt · 2024-12-20T20:11:49Z

.circleci/config.yml

@@ -167,7 +167,6 @@ workflows:
          requires:
            - prep-deps
      - prep-build-test-flask-mv2:
-          <<: *main_master_rc_only


We need to build it on all PRs in order to include the build link

metamaskbot · 2024-12-20T20:53:42Z

Builds ready [be80ecb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1622 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	252	1912	1561	315	151
		domContentLoaded	1452	1852	1602	94	45
		load	1460	1903	1622	98	47
		domInteractive	22	147	45	31	15
		backgroundConnect	8	51	28	18	9
		firstReactRender	16	94	31	26	12
		getState	4	49	13	15	7
		initialActions	0	1	0	0	0
		loadScripts	1020	1380	1167	81	39
		setupStore	6	51	13	14	7
		uiStartup	1617	2208	1877	151	73

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Gudahtt · 2024-12-20T21:00:37Z

.circleci/config.yml

@@ -783,10 +786,10 @@ jobs:
          name: Build extension for testing
          command: yarn build:test:flask:mv2
      - run:
-          name: Move test build to 'dist-test-flask' to avoid conflict with production build
+          name: Move test build to 'dist-test-flask-mv2' to avoid conflict with production build


These two changes were copy+paste mistakes in the step description

Gudahtt · 2024-12-20T21:01:06Z

.circleci/config.yml

      - store_artifacts:
          path: builds-test-flask
+      - store_artifacts:
+          path: builds-test-flask-mv2


This was the main issue with the broken test MV2 build links: we forgot toe store_artifacts step.

Various build links in the `metamaskbot` PR comment were broken. All links have been fixed except beta (which is trickier to fix, requires more substantial changes to the beta workflows). Additionally, validation was added to verify each build link, omitting any that are not working from the comment (and logging warning).

metamaskbot · 2024-12-20T21:49:49Z

Builds ready [de0f2dd]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1857 ± 110 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	892	2245	1773	261	125
		domContentLoaded	1552	2491	1823	225	108
		load	1596	2507	1857	228	110
		domInteractive	26	207	61	54	26
		backgroundConnect	10	74	34	19	9
		firstReactRender	18	100	37	24	12
		getState	7	86	27	24	12
		initialActions	0	0	0	0	0
		loadScripts	1113	1995	1333	195	94
		setupStore	6	75	22	23	11
		uiStartup	1762	2779	2130	260	125

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Gudahtt added the team-extension-platform label Dec 20, 2024

metamaskbot added the team-wallet-framework label Dec 20, 2024

Gudahtt changed the title ~~ci: Fix metamaskbot comment build links~~ ci: Fix metamaskbot comment test build links Dec 20, 2024

Gudahtt commented Dec 20, 2024

View reviewed changes

Gudahtt force-pushed the fix-metamaskbot-build-links branch 2 times, most recently from 35b4b48 to 6ec646c Compare December 20, 2024 18:17

Gudahtt commented Dec 20, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

Gudahtt force-pushed the fix-metamaskbot-build-links branch from 9b86dbc to 440bb95 Compare December 20, 2024 20:02

Gudahtt commented Dec 20, 2024

View reviewed changes

Gudahtt mentioned this pull request Dec 20, 2024

[Bug]: metamaskbot broken beta build links #29404

Open

Gudahtt commented Dec 20, 2024

View reviewed changes

Gudahtt added 7 commits December 20, 2024 17:31

Skip labels with no builds

b1d9ed9

Fix comment build link formatting

016f315

Remove validation

dad8928

Fix webpack and test-flask-mv2 builds, remove test-mmi

d679d4c

Remove webpack build link (no zips)

f694c71

Remove beta link

de0f2dd

Gudahtt force-pushed the fix-metamaskbot-build-links branch from 8e1220a to de0f2dd Compare December 20, 2024 21:01

Gudahtt marked this pull request as ready for review December 20, 2024 21:54

Gudahtt requested a review from a team as a code owner December 20, 2024 21:54

Gudahtt mentioned this pull request Dec 20, 2024

ci: Migrate metamaskbot PR comment #29373

Open

7 tasks

hjetpoluru self-requested a review December 20, 2024 23:32

hjetpoluru approved these changes Dec 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Fix `metamaskbot` comment test build links #29403

ci: Fix `metamaskbot` comment test build links #29403

Gudahtt commented Dec 20, 2024 •

edited

Loading

Gudahtt Dec 20, 2024

Gudahtt Dec 20, 2024

Gudahtt Dec 20, 2024

This comment was marked as outdated.

This comment was marked as outdated.

Gudahtt Dec 20, 2024

metamaskbot commented Dec 20, 2024

Gudahtt Dec 20, 2024

Gudahtt Dec 20, 2024 •

edited

Loading

metamaskbot commented Dec 20, 2024

ci: Fix metamaskbot comment test build links #29403

Are you sure you want to change the base?

ci: Fix metamaskbot comment test build links #29403

Conversation

Gudahtt commented Dec 20, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Gudahtt Dec 20, 2024

Choose a reason for hiding this comment

Gudahtt Dec 20, 2024

Choose a reason for hiding this comment

Gudahtt Dec 20, 2024

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

Gudahtt Dec 20, 2024

Choose a reason for hiding this comment

metamaskbot commented Dec 20, 2024

Gudahtt Dec 20, 2024

Choose a reason for hiding this comment

Gudahtt Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Dec 20, 2024

ci: Fix `metamaskbot` comment test build links #29403

ci: Fix `metamaskbot` comment test build links #29403

Gudahtt commented Dec 20, 2024 •

edited

Loading

Gudahtt Dec 20, 2024 •

edited

Loading