ci: Migrate metamaskbot PR comment #29373
Open
+128
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
migrate-metamaskbot-comment
branch
4 times, most recently
from
051cd52 to
3cbc139
Compare
Builds ready [6a4182e]
Bundle size diffs
|
Builds ready [dc9fd81]
Page Load Metrics (1422 ± 42 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [fb737b2]
Page Load Metrics (1766 ± 68 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [44f95d4]
Page Load Metrics (1610 ± 85 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Gudahtt
force-pushed
the
migrate-metamaskbot-comment
branch
from
54e05e1 to
0bce5e0
Compare
Builds ready [0bce5e0]
Page Load Metrics (1771 ± 75 ms)
Bundle size diffs
|
Gudahtt
force-pushed
the
migrate-metamaskbot-comment
branch
from
0bce5e0 to
e10477e
Compare
Gudahtt
commented
Dec 20, 2024
| @@ -9,7 +9,7 @@ async function getHighlights({ artifactBase }) { | |||
| // here we assume the PR base branch ("target") is `main` in lieu of doing | |||
| // a query against the github api which requires an access token | |||
| // see https://discuss.circleci.com/t/how-to-retrieve-a-pull-requests-base-branch-name-github/36911 | |||
| const changedFiles = await getChangedFiles({ target: 'main' }); | |||
| const changedFiles = await getChangedFiles({ target: 'origin/main' }); | |||
There was a problem hiding this comment.
This is now running on GitHub Actions rather than CircleCI, which doesn't checkout the main branch locally. origin/main works across both CI systems.
Gudahtt
commented
Dec 20, 2024
| BRANCH: ${{ github.head_ref }} | ||
| HEAD_COMMIT_HASH: ${{ github.event.pull_request.head.sha }} | ||
| run: | | ||
| pipeline_id=$(curl --silent "https://circleci.com/api/v2/project/gh/$OWNER/$REPOSITORY/pipeline?branch=$BRANCH" | jq -r ".items | map(select(.vcs.revision == \"${HEAD_COMMIT_HASH}\" )) | first | .id") |
There was a problem hiding this comment.
Same strategy as used elsewhere for getting the CircleCI workflow corresponding to the current branch+commit:
Gudahtt
commented
Dec 20, 2024
|
|
||
| echo "Getting artifacts from pipeline '${pipeline_id}', workflow '${workflow_id}', build number '${build_num}', job ID '${job_id}'" | ||
|
|
||
| - name: Get CircleCI job artifacts |
There was a problem hiding this comment.
Most of the artifacts referenced in the metamaskbot comment are referenced by CircleCI artifact link. We didn't need to download those.
These three are pulled from the filesystem by the script though, so we needed to download these.
Gudahtt
commented
Dec 20, 2024
| PR_COMMENT_TOKEN: ${{ secrets.PR_COMMENT_TOKEN }} | ||
| PR_NUMBER: ${{ github.event.pull_request.number }} | ||
| HEAD_COMMIT_HASH: ${{ github.event.pull_request.head.sha }} | ||
| MERGE_BASE_COMMIT_HASH: ${{ steps.get-merge-base.outputs.MERGE_BASE }} |
There was a problem hiding this comment.
This is equivalent to the PARENT_COMMIT used previously, they both use git merge-base to find the base commit between the current branch and the target branch.
Gudahtt
commented
Dec 20, 2024
| const sourceMapRoot = '/build-artifacts/source-map-explorer/'; | ||
| const bundleFiles = await glob(`.${sourceMapRoot}*${fileType}`); |
There was a problem hiding this comment.
The strategy used to collect these links was changed. Previously we used glob to look for these files on the filesystem. It would have been tedious to migrate each file one-by-one between CI systems, so instead we're hard-coding the 5 bundle types and testing each bundle index until we get a 404.
This ensures the links are constructed correctly even as the number of bundles fluctuates (which is common), and it doesn't require transferring the files between CI systems.
Builds ready [2727f61]
Page Load Metrics (1783 ± 125 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the
metamaskbotPR comment from CircleCI to GitHub Actions. CircleCI is still used for artifact storage for linked artifacts.Related issues
Relates to #28572
These changes were extracted from #29256
Manual testing steps
metamaskbotcomment work correctly, except those that are already broken. Links already broken onmaininclude:metamaskbotcomment test build links #29403 ):Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist