Feature/interactive aliases #154
Conversation
|
Hi everybody, I wish to know if there are some problems with this PR or it can be merged? |
There was a problem hiding this comment.
Hi @ZappaBoy,
Thanks so much for creating a PR for your feature request 👍
I tested it and it works well.
I left a couple of comments that I'd like you to address, and then I'm happy to merge it into the main branch.
src/dmenu_extended/main.py
Outdated
| @@ -750,7 +751,10 @@ def execute(self, command, fork=None): | |||
| print("Command converted into:") | |||
| print(command) | |||
|
|
|||
| return subprocess.call(command) | |||
| if self.prefs["interactive_shell"] is True: | |||
| shell = os.environ.get("SHELL", "/bin/bash") | |||
There was a problem hiding this comment.
Rather than "/bin/bash" how about "/usr/bin/env bash" to handle compatibility with systems that don't have bash under the /bin directory.
There was a problem hiding this comment.
I perfectly agree with you. Changed in 0a30a44 .
src/dmenu_extended/main.py
Outdated
| @@ -203,6 +203,7 @@ def unsatisfied_plugin_requirements(plugin): | |||
| "indicator_edit": "*", # Symbol to indicate an item will launch an editor | |||
| "indicator_alias": "", # Symbol to indicate an aliased command | |||
| "prompt": "Open:", # Prompt | |||
| "interactive_shell": False, # Run commands in interactive mode | |||
There was a problem hiding this comment.
For the comment, how about "Run commands in an interactive shell session".
There was a problem hiding this comment.
Changed in 0a30a44 .
Moved interactive shell to "/usr/bin/env bash" to improve compatibility; Referred to MarkHedleyJones#154 #discussion_r1014608222.
…o feature/interactive-aliases
|
I also increased the version string, now the CI pipeline will run successfully. |
Add acknowledgement
Concerning #152 I added the functionality of executing commands via interactive shell.
I tried to be as minimally invasive as possible by making few changes and respecting the programming style.
By default the feature is off but by setting the "interactive_shell" property to "True" in preferences the commands are executed based on the shell set (
$SHELLenv)This is only a first step as processes launched in the background are not shown to the user but I am working on it in my spare time.
Anyway I am submitting these changes since I don't know when I can work on them due to my jobs.
Also finished this feature I would like to do a minimum of refactoring always free time permitting.