Feature/interactive aliases (#154)

* Added interactive process call * Fixed lint quote warning; * Run commands in interactive mode * Changed interactive shell comment; Moved interactive shell to "/usr/bin/env bash" to improve compatibility; Referred to #154 #discussion_r1014608222. * Increased version; * Update README.md Add acknowledgement Co-authored-by: Mark Hedley Jones <[email protected]>
MarkHedleyJones · Nov 20, 2022 · 3cd31bc · 3cd31bc
1 parent 7ad25c0
commit 3cd31bc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -290,3 +290,4 @@ For those looking to improve the code, the code uses [Black](https://github.com/
 * [**nanobecquerel**](https://github.com/nanobecquerel) for improving systemd integration
 * [**fat-fighter**](https://github.com/fat-fighter) for bug fixes and solving GitHub issues
 * [**vestingz**](https://github.com/vestingz) for Incron and pacman integration.
+* [**ZappaBoy**](https://github.com/ZappaBoy) for improving alias/shell integration
diff --git a/pyproject.toml b/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "dmenu_extended"
-version = "1.1.4"
+version = "1.2.0"
 authors = [
   { name="Mark Hedley Jones", email="[email protected]" },
 ]

diff --git a/src/dmenu_extended/main.py b/src/dmenu_extended/main.py
@@ -203,6 +203,7 @@ def unsatisfied_plugin_requirements(plugin):
     "indicator_edit": "*",  # Symbol to indicate an item will launch an editor
     "indicator_alias": "",  # Symbol to indicate an aliased command
     "prompt": "Open:",  # Prompt
+    "interactive_shell": False,  # Run commands in an interactive shell session
 }
 
 
@@ -750,7 +751,10 @@ def execute(self, command, fork=None):
             print("Command converted into:")
             print(command)
 
-        return subprocess.call(command)
+        if self.prefs["interactive_shell"] is True:
+            shell = os.environ.get("SHELL", "/usr/bin/env bash")
+            command = shell + " -i -c " + " ".join(command)
+        return subprocess.call(command, shell=self.prefs["interactive_shell"])
 
     def cache_regenerate(self, message=True):
         if message: