Fix some sonar warnings #3839

MaibornWolff · Feb 11, 2025 · 5ebb8a8 · 5ebb8a8
1 parent 8e7e8de
commit 5ebb8a8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/visualization/app/codeCharta/ui/codeMap/threeViewer/threeMapControls.service.ts b/visualization/app/codeCharta/ui/codeMap/threeViewer/threeMapControls.service.ts
@@ -13,12 +13,12 @@ type CameraChangeEvents = {
 
 @Injectable({ providedIn: "root" })
 export class ThreeMapControlsService {
-    static CAMERA_CHANGED_EVENT_NAME = "camera-changed"
+    static readonly CAMERA_CHANGED_EVENT_NAME = "camera-changed"
     MAX_ZOOM = 200
     MIN_ZOOM = 10
 
     controls: MapControls
-    private eventEmitter = new EventEmitter<CameraChangeEvents>()
+    private readonly eventEmitter = new EventEmitter<CameraChangeEvents>()
     zoomPercentage$ = new BehaviorSubject<number>(100)
 
     constructor(

diff --git a/visualization/app/codeCharta/ui/ribbonBar/showScenariosButton/scenario.service.ts b/visualization/app/codeCharta/ui/ribbonBar/showScenariosButton/scenario.service.ts
@@ -30,11 +30,11 @@ import { ScenarioHelper } from "./scenarioHelper"
 @Injectable({ providedIn: "root" })
 export class ScenarioService {
     constructor(
-        private state: State<CcState>,
-        private store: Store<CcState>,
-        private dialog: MatDialog,
-        private threeCameraService: ThreeCameraService,
-        private threeOrbitControlsService: ThreeMapControlsService
+        private readonly state: State<CcState>,
+        private readonly store: Store<CcState>,
+        private readonly dialog: MatDialog,
+        private readonly threeCameraService: ThreeCameraService,
+        private readonly threeOrbitControlsService: ThreeMapControlsService
     ) {}
 
     getScenarios() {