Refactor method #3839

MaibornWolff · Feb 11, 2025 · 8e7e8de · 8e7e8de
1 parent e7d7146
commit 8e7e8de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/visualization/app/codeCharta/ui/codeMap/threeViewer/threeMapControls.service.ts b/visualization/app/codeCharta/ui/codeMap/threeViewer/threeMapControls.service.ts
@@ -31,6 +31,10 @@ export class ThreeMapControlsService {
         this.controls.target.set(cameraTarget.x, cameraTarget.y, cameraTarget.z)
     }
 
+    updateControls() {
+        this.controls.update()
+    }
+
     rotateCameraInVectorDirection(x: number, y: number, z: number) {
         const zoom = this.getZoom()
         this.lookAtDirectionFromTarget(x, y, z)
@@ -51,7 +55,7 @@ export class ThreeMapControlsService {
 
             cameraReference.position.set(length, length, boundingSphere.center.z)
 
-            this.controls.update()
+            this.updateControls()
 
             this.focusCameraViewToCenter(boundingSphere)
             this.threeRendererService.render()
@@ -190,7 +194,7 @@ export class ThreeMapControlsService {
         const newDistance = this.getDistanceFromZoomPercentage(zoom)
         const direction = new Vector3().subVectors(this.threeCameraService.camera.position, this.controls.target).normalize()
         this.threeCameraService.camera.position.copy(this.controls.target).add(direction.multiplyScalar(newDistance))
-        this.controls.update()
+        this.updateControls()
 
         this.zoomPercentage$.next(zoom)
     }

diff --git a/visualization/app/codeCharta/ui/ribbonBar/showScenariosButton/scenario.service.ts b/visualization/app/codeCharta/ui/ribbonBar/showScenariosButton/scenario.service.ts
@@ -92,7 +92,7 @@ export class ScenarioService {
             this.threeCameraService.setPosition(scenario.camera.camera)
             // @ts-ignore -- we know that it is not a partial when it is set
             this.threeOrbitControlsService.setControlTarget(scenario.camera.cameraTarget)
-            this.threeOrbitControlsService.controls.update()
+            this.threeOrbitControlsService.updateControls()
         }
     }