-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed to dynamically ignore incorrect achievement data. #567
base: main
Are you sure you want to change the base?
Conversation
Added a function to ignore extraneous data included in the JSON data. The JSON data is expected to be mechanically generated, so modifying the JSON data itself was considered inappropriate.
I fully understand that my points on this issue are duplicative. On top of that, the moderators continue to ignore it, so I am going out of my way to propose a new approach. I question why you continue to ignore all these points. I suspect there is malice in that. In any case, if you are not willing to take this issue seriously, I will not use this site again. Goodbye. |
I'm seconding what @shintaxx has mentioned. While I understand that we're not in the position to demand anything because we're not paying to use the site, it's a bit disheartening to see these still up. It's close to a year since they were noticed. Why haven't they been fixed? The site so behind on so many relevant elements... Spincrystals haven't been updated. Furniture sets haven't been updated. TCG cards haven't been updated. I'm better off assuming it's dead... |
I just triage stuff around here. It's up to @MadeBaruna to apply and merge fixes. The Discord server community is pretty active (despite its lawlessness) and community run alternatives are routinely discussed/under development (check out dval.in) |
@shintaxx @inoffensive I'm one of those who has been driven mad by this, too. I finally have the beginnings of a solution that does not depend on source code modifications by leveraging Chromium's "local overrides" feature to modify the service worker. I'd like to share in case you have the bandwidth to complete it. Discaimers:
Steps:
self.addEventListener("fetch", async (e) => {
e.request.url.indexOf(self.location.origin) !== 0 || e.request.method !== "GET" || e.respondWith((async () => {
const a = e.request.url.indexOf(f) === 0 ? r : n, c = await caches.open(a), t = await c.match(e.request);
if (t)
return t;
// START of modification
// const s = await fetch(e.request);
let s = await fetch(e.request);
if (e.request.url.startsWith("https://paimon.moe/_app/immutable/pages/achievement/index.svelte-")) {
const body = await s.text();
const newBody = body.replaceAll(/\{id:(?:81416|81418|81426|81429|81451|81453),name:"[^"]+",desc:"[^"]+",reward:\d+,ver:"[^"]+"},?/g, "");
const newResponse = new Response(newBody, { headers: { 'Content-Type': 'application/javascript' } } );
s = newResponse;
}
// END of modification
return s.ok && c.put(e.request, s.clone()), s;
})());
});
Let me know how it goes or if you encounter any problems. I'll probably be more responsive than Baruna 👍 |
Added a function to ignore extraneous data included in the JSON data. The JSON data is expected to be mechanically generated, so modifying the JSON data itself was considered inappropriate.