Remove entries for non-existent achievements. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I've removedd problematic achievements from
src/data/achievements/xx.jsonfor all languages in there. The false ones that I was able to identify are the following:81416: Measure of Interference81418: Gentle Descent81453: Hanging Gardens of Plucked JadeI've found various sources that state that these may have been present in beta versions and datamined into paimon.moe, but they aren't obtainable in-game and have plagued the site since 4.2 (also 4.4).
This might fix part of #557 and most of the other issues related to non-existent achievements in Wonders of the World.
Any feedback or suggestions are appreciated, in case I've missed any achievements or there are more entries that need removing.