-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: campaign_ensure_chapter incorrect due to slow animation #3676
base: dev
Are you sure you want to change the base?
Conversation
module/campaign/campaign_ui.py
Outdated
if diff == 0: | ||
break | ||
# index=4, current=4, actual=14 | ||
error_confirm_2.start() | ||
if not error_confirm_2.reached(): | ||
continue | ||
else: | ||
break | ||
else: | ||
error_confirm_2.clear() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在正常流程中不应有多余的截图或等待
正常流程指,预期切换到3图 实际也是3图,不需要切换章节的情况
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
预期(index)切换到3图 实际(actual)也是3图,这样和“不正常”的流程一样index=3, current=3
,除了多截一次图没有其他办法可以确定current==actual
5baad52
to
9c37bf4
Compare
减少一个timer,这样测着没啥问题。我们永远无法得知实际(actual)值,只能通过多截图/等待来增大current=actual的概率 while True:
self.device.click_record_clear()
self.ui_goto_main()
self.campaign.campaign_set_chapter_main('13')
self.ui_goto_main()
self.campaign.campaign_set_chapter_main('13')
self.ui_goto_main()
self.campaign.campaign_set_chapter_main('3') |
需要解决这个问题,否则PR不会被接受 |
想要没有多余的截图或等待,就要有“多余”的ocr和多服务器适配,或者“多余”的错误和重启。 |
修复选择3-4但由于将13-4识别为3-4而出击13-4的问题