Skip to content

refactor(packaging/windows): installer script execution#4675

Merged
ReenigneArcher merged 1 commit intomasterfrom
refactor/packaging/windows-installer-script-execution
Feb 7, 2026
Merged

refactor(packaging/windows): installer script execution#4675
ReenigneArcher merged 1 commit intomasterfrom
refactor/packaging/windows-installer-script-execution

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Feb 6, 2026

Description

Refactors windows installer script execution. There is now a primary script which will handle the majority of the install / uninstall steps instead of dealing with nsis logic, and in the future wix logic.

Also adds logging for the nsis installer, and additional logging for the new powershell script. The nsis logging is not very useful, but still nice to add this.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the refactor/packaging/windows-installer-script-execution branch from a7c1353 to 30f7c70 Compare February 6, 2026 04:33
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@bf574af). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4675   +/-   ##
=========================================
  Coverage          ?   13.73%           
=========================================
  Files             ?       95           
  Lines             ?    19744           
  Branches          ?     9076           
=========================================
  Hits              ?     2712           
  Misses            ?    13761           
  Partials          ?     3271           
Flag Coverage Δ
Archlinux 11.20% <ø> (?)
FreeBSD-14.3-amd64 13.24% <ø> (?)
Windows-AMD64 13.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the refactor/packaging/windows-installer-script-execution branch 9 times, most recently from c334afd to ecf2687 Compare February 7, 2026 02:41
@ReenigneArcher ReenigneArcher marked this pull request as ready for review February 7, 2026 02:41
@ReenigneArcher ReenigneArcher force-pushed the refactor/packaging/windows-installer-script-execution branch 4 times, most recently from c7e1af7 to 79829e2 Compare February 7, 2026 04:05
@ReenigneArcher ReenigneArcher force-pushed the refactor/packaging/windows-installer-script-execution branch from 79829e2 to 934f2e7 Compare February 7, 2026 16:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2026

@ReenigneArcher ReenigneArcher merged commit e2652fa into master Feb 7, 2026
52 of 53 checks passed
@ReenigneArcher ReenigneArcher deleted the refactor/packaging/windows-installer-script-execution branch February 7, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant