refactor(packaging/windows): installer script execution#4675
Merged
ReenigneArcher merged 1 commit intomasterfrom Feb 7, 2026
Merged
Conversation
19 tasks
a7c1353 to
30f7c70
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4675 +/- ##
=========================================
Coverage ? 13.73%
=========================================
Files ? 95
Lines ? 19744
Branches ? 9076
=========================================
Hits ? 2712
Misses ? 13761
Partials ? 3271
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bundle ReportBundle size has no change ✅ |
c334afd to
ecf2687
Compare
c7e1af7 to
79829e2
Compare
79829e2 to
934f2e7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Refactors windows installer script execution. There is now a primary script which will handle the majority of the install / uninstall steps instead of dealing with nsis logic, and in the future wix logic.
Also adds logging for the nsis installer, and additional logging for the new powershell script. The nsis logging is not very useful, but still nice to add this.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage