feat(installer/windows): add wix installer#3916
feat(installer/windows): add wix installer#3916ReenigneArcher wants to merge 1 commit intomasterfrom
Conversation
14ce5ed to
f20af0e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3916 +/- ##
==========================================
- Coverage 15.17% 15.14% -0.04%
==========================================
Files 95 95
Lines 19874 19874
Branches 9178 9178
==========================================
- Hits 3016 3009 -7
+ Misses 15685 15003 -682
- Partials 1173 1862 +689
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bundle ReportBundle size has no change ✅ |
9e4b955 to
6ef5e6e
Compare
|
|
The latest NSIS version now runs properly on ARM64 systems, so we can stick with NSIS if we want. WiX does make it easier to support having a single unified installer for both x64 and ARM64 binaries if we want that. |
|
Good to know. I still need to setup a VM to test this out. I think msi would still be nice to use, especially for anyone installing Sunshine with a script as it supports more CLI options. I discovered in a recent change that I couldn't even get the output of the installer scripts to a log file with NSIS. Do you know the process for unifying the installer? That would be pretty nice. |
c3efb02 to
07c0044
Compare
07c0044 to
805e270
Compare
This comment was marked as outdated.
This comment was marked as outdated.
46f307b to
b57a26e
Compare
a348849 to
a6dbf17
Compare
a6dbf17 to
e18cc13
Compare
|
This is basically working now, just need to nail down a few things.
Any preference? I think I will also have one single script that calls all the other scripts, especially if we're going to have the window show. And then output the stdout out from the script to a log file, as currently I don't think this is logged by the msi installer. |
This comment was marked as resolved.
This comment was marked as resolved.
e18cc13 to
e117752
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
e117752 to
59eaea1
Compare
59eaea1 to
953c971
Compare
|
This comment was marked as off-topic.
This comment was marked as off-topic.
PR is draft, review not requested. I already have updating docs on the todo in the PR request body. |



Description
This PR adds a WIX installer for Sunshine. The NSIS installer will be removed at a later point after any bugs with the WIX installer are ironed out.
This is a requirement for having an ARM64 installer for #3905 or #3369
TODO:
For first release after this is merged, we will keep both exe and msi, so that the winget automation will still work to auto update winget. We will then to update winget manually to use the msi
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist