fix: correct append_struct reserve calculation and optimize insertion#4416
Closed
chaowyc wants to merge 1 commit intoLizardByte:masterfrom
Closed
fix: correct append_struct reserve calculation and optimize insertion#4416chaowyc wants to merge 1 commit intoLizardByte:masterfrom
chaowyc wants to merge 1 commit intoLizardByte:masterfrom
Conversation
This patch fixes two issues in append_struct(): 1. Fixed reserve() calculation: Changed from reserve(data_len) to reserve(buf.size() + data_len) to correctly account for existing buffer size. The original code could fail to allocate sufficient space when the buffer already contains data. 2. Optimized insertion: Replaced loop with N push_back() calls with a single insert() operation, reducing function call overhead and avoiding potential mid-loop reallocations.
|
Member
|
This appears to be a duplicate of your other PR #4415 |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This patch fixes two issues in append_struct():
Fixed reserve() calculation: Changed from reserve(data_len) to
reserve(buf.size() + data_len) to correctly account for existing
buffer size. The original code could fail to allocate sufficient
space when the buffer already contains data.
Optimized insertion: Replaced loop with N push_back() calls with
a single insert() operation, reducing function call overhead and
avoiding potential mid-loop reallocations.
Screenshot
N/A
Issues Fixed or Closed
N/A - This addresses a bug identified through code analysis.
Roadmap Issues
N/A
Type of Change
Checklist
AI Usage