This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
LL-2041 - Feature: Persist all market page settings in store #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution.
Why /generate-screenshots ?If your PR contains UI related changes, |
nparigi-ledger
changed the title
nparigi-ledger
commented
May 6, 2022
| @@ -335,61 +357,63 @@ export default function Market({ navigation }: { navigation: any }) { | |||
|
|
|||
| const renderEmptyComponent = useCallback( | |||
| () => | |||
| search ? ( // shows up in case of no search results | |||
There was a problem hiding this comment.
This whole part is just lint to the end of the file
There was a problem hiding this comment.
I hope you didn't sneak in an easter egg hoping we just trust you and don't review the end of the file 👀
ofreyssinet-ledger
approved these changes
May 9, 2022
ychen-ledger
approved these changes
May 17, 2022
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen_Recording_20220506-145555_LL.DEV.mp4
Store all the parameters (sort, time, currency, show favorite) in the store so nothing change when you open again the market page even after restarting the app.
Type
Feature
Context
https://ledgerhq.atlassian.net/browse/LIVE-2041
Parts of the app affected / Test plan
Market page