Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LL-2041 - Feature: Persist all market page settings in store #71

Conversation

nparigi-ledger
Copy link
Contributor

❓ Context

Store all the parameters from the market page (sort, time, currency, show favorite) in the store so nothing change when you open it again even after restarting the app.

✅ Checklist

  • Test coverage: Did you write any tests to cover the changes introduced by this pull request?
  • Atomic delivery: Is this pull request standalone? In order words, does it depend on nothing else?
  • Breaking changes: Does this pull request contain breaking changes of any kind? If so, please explain why.

📸 Demo

Screen_Recording_20220506-145555_LL.DEV.mp4

🚀 Expectations to reach

Note: This a PR migrated from LedgerHQ/ledger-live-mobile#2492 it's already reviewed and QAed

@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-github-bot ✅ Ready (Inspect) Visit Preview May 24, 2022 at 3:12PM (UTC)
live-common-tools ✅ Ready (Inspect) Visit Preview May 24, 2022 at 3:12PM (UTC)
2 Ignored Deployments
Name Status Preview Updated
native-ui-storybook ⬜️ Ignored (Inspect) May 24, 2022 at 3:12PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) May 24, 2022 at 3:12PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2022

⚠️ No Changeset found

Latest commit: 6a51144

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label May 18, 2022
@nparigi-ledger nparigi-ledger changed the title Feat/live 2041 market page persist all settings LL-2041 - Feature: Persist all market page settings in store May 18, 2022
@nparigi-ledger nparigi-ledger marked this pull request as ready for review May 18, 2022 14:46
@github-actions
Copy link

github-actions bot commented May 18, 2022

@nparigi-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

: marketCounterCurrency // If there is a stored market counter currency we use it, otherwise we use the setting countervalue currency
? { ticker: marketCounterCurrency }
: counterValueCurrency
? // @TODO move this toLowercase check on live-common
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu fais ce Todo maintenant qu'on est sur le monorepo ?

@nparigi-ledger nparigi-ledger changed the base branch from develop to releases/llm-3.2.x May 24, 2022 08:22
@nparigi-ledger nparigi-ledger force-pushed the feat/LIVE-2041-market-page-persist-all-settings branch from 30b562f to 497a628 Compare May 24, 2022 15:09
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #71 (30b562f) into releases/llm-3.2.x (6da97e4) will not change coverage.
The diff coverage is n/a.

❗ Current head 30b562f differs from pull request most recent head 6a51144. Consider uploading reports for the commit 6a51144 to get more accurate results

@@           Coverage Diff            @@
##   releases/llm-3.2.x   #71   +/-   ##
========================================
========================================

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da97e4...6a51144. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants