-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LL-2041 - Feature: Persist all market page settings in store #71
LL-2041 - Feature: Persist all market page settings in store #71
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
: marketCounterCurrency // If there is a stored market counter currency we use it, otherwise we use the setting countervalue currency | ||
? { ticker: marketCounterCurrency } | ||
: counterValueCurrency | ||
? // @TODO move this toLowercase check on live-common |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tu fais ce Todo maintenant qu'on est sur le monorepo ?
30b562f
to
497a628
Compare
Codecov Report
@@ Coverage Diff @@
## releases/llm-3.2.x #71 +/- ##
========================================
========================================
Continue to review full report at Codecov.
|
❓ Context
Store all the parameters from the market page (sort, time, currency, show favorite) in the store so nothing change when you open it again even after restarting the app.
✅ Checklist
📸 Demo
Screen_Recording_20220506-145555_LL.DEV.mp4
🚀 Expectations to reach
Note: This a PR migrated from LedgerHQ/ledger-live-mobile#2492 it's already reviewed and QAed