Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Flex support #74

Merged
merged 10 commits into from
Jul 25, 2024
Merged

Add Flex support #74

merged 10 commits into from
Jul 25, 2024

Conversation

agrojean-ledger
Copy link

@agrojean-ledger agrojean-ledger commented Jul 19, 2024 •
edited
Loading

Changelog

  • Add flex support,
  • Update Makefile to standard format,
  • Fix headless mode on Nano X / SP for integration tests running,
  • Update some NBGL calls to latest API (main menu),
  • Add integration tests in CI using ledgerjs-cardano-shelley

Checklist

  • Target branch is develop
  • Application version has been bumped

@agrojean-ledger agrojean-ledger changed the title Add flex Add Flex support Jul 19, 2024
agrojean-ledger
agrojean-ledger commented Jul 19, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
tdejoigny-ledger
tdejoigny-ledger reviewed Jul 19, 2024
View reviewed changes
Copy link

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog and readme files need to be updated

Makefile Outdated Show resolved Hide resolved
src/uiHelpers.c Outdated Show resolved Hide resolved
src/uiHelpers.h Outdated Show resolved Hide resolved
src/ui_menu_nbgl.c Show resolved Hide resolved
src/ui_menu_nbgl.c Show resolved Hide resolved
src/ui_nbgl.c Show resolved Hide resolved
src/ui_menu_nbgl.c Show resolved Hide resolved
@tdejoigny-ledger
Copy link

tdejoigny-ledger commented Jul 19, 2024 •
edited
Loading

and as discussed
could be good to add https://github.com/vacuumlabs/ledgerjs-cardano-shelley?tab=readme-ov-file#tests in the CI

@agrojean-ledger agrojean-ledger force-pushed the add-flex branch 13 times, most recently from 70391b8 to fc148fe Compare July 22, 2024 14:42
@agrojean-ledger agrojean-ledger merged commit 33c0ffb into develop Jul 25, 2024
38 checks passed
@agrojean-ledger agrojean-ledger deleted the add-flex branch July 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger approved these changes

@fbeutin-ledger fbeutin-ledger Awaiting requested review from fbeutin-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agrojean-ledger @tdejoigny-ledger