Skip to content

Commit

Permalink
PR review.
Browse files Browse the repository at this point in the history
  • Loading branch information
agrojean-ledger committed Jul 24, 2024
1 parent 4143bed commit df6d34f
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 8 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [7.2.0](TBD) - [TBD]

### Added

- Add flex support,
- Add integration tests in CI using [ledgerjs-cardano-shelley](https://github.com/LedgerHQ/ledgerjs-cardano-shelley)

### Changed

- Update Makefile to standard format,
- Fix headless mode on Nano X / SP for integration tests running,
- Update some NBGL calls to latest API (main menu),

## [7.1.0](TBD) - [TBD]

Expand Down
5 changes: 0 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,6 @@ SDK_SOURCE_PATH += lib_u2f
##############
# Compiler #
##############

# based in part on https://interrupt.memfault.com/blog/best-and-worst-gcc-clang-compiler-flags
WERROR := -Werror=return-type -Werror=parentheses -Werror=format-security
CFLAGS += -Wuninitialized -fno-common $(WERROR)

## USB U2F
DEFINES += HAVE_U2F HAVE_IO_U2F U2F_PROXY_MAGIC=\"ADA\" USB_SEGMENT_SIZE=64

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Cardano Ledger App

Cardano Ledger App for Ledger Nano S
Cardano Ledger App for Ledger devices (Nano S, Nano S Plus, Nano X, Stax, Flex)

## Building

Expand Down
2 changes: 1 addition & 1 deletion src/uiHelpers.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ displayState_t displayState;
// ux is a magic global variable implicitly referenced by the UX_ macros. Apps
// should never need to reference it directly
ux_state_t ux;
#elif defined(TARGET_NANOX) || defined(TARGET_NANOS2) || defined(TARGET_STAX) || defined(TARGET_FLEX)
#else
ux_state_t G_ux;
bolos_ux_params_t G_ux_params;
#endif
Expand Down
2 changes: 1 addition & 1 deletion src/uiHelpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

typedef void ui_callback_fn_t();

#if defined(TARGET_NANOX) || defined(TARGET_NANOS2) || defined(TARGET_STAX) || defined(TARGET_FLEX)
#if !defined(TARGET_NANOS)
extern ux_state_t G_ux;
extern bolos_ux_params_t G_ux_params;
#endif
Expand Down

0 comments on commit df6d34f

Please sign in to comment.