Code

MuSig2 support#294

Code

Merged

bigspider merged 57 commits intodevelopLedgerHQ/app-bitcoin-new:developfrom musig2LedgerHQ/app-bitcoin-new:musig2Copy head branch name to clipboardDec 10, 2024

+6,095-950

Commits

Commits on Nov 4, 2024

• Added parsing for musig(); generalized key placeholders in wallet policies to more general key expressions

  bigspider

  committed
  f962150

  Copy full SHA for f962150

• Rename "key placeholder" with "key expression" where appropriate; added some comments.

  Show description for 5efbc36
  bigspider

  committed
  5efbc36

  Copy full SHA for 5efbc36

• Refactored policy_node_keyexpr_t to explicitly label which of the union type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.

  bigspider

  committed
  8e24994

  Copy full SHA for 8e24994

• Add PSBT constants related to MuSig2; deleted unused constant

  bigspider

  committed
  3dbf464

  Copy full SHA for 3dbf464

• Moved secp256k1 constants to a separate module

  bigspider

  committed
  92f1b54

  Copy full SHA for 92f1b54

• Added address generation tests for musig

  bigspider

  committed
  4e6bae5

  Copy full SHA for 4e6bae5

• Made crypto_tr_lift_x and crypto_tr_tagged_hash functions public

  bigspider

  committed
  654e1e2

  Copy full SHA for 654e1e2

• Musig key aggregation and address generation

  bigspider

  committed
  bbde126

  Copy full SHA for bbde126

• Compute aggregate xpub for musig() in descriptors in the python client library

  bigspider

  committed
  7b7af76

  Copy full SHA for 7b7af76

Commits on Nov 6, 2024

• Add musig2 fields to PSBT class

  bigspider

  committed
  4ebfc25

  Copy full SHA for 4ebfc25

• Added python standalone implementation of MuSig2 signing, and tests

  bigspider

  committed
  9f48eb8

  Copy full SHA for 9f48eb8

• Add 'tweak' output parameter to bip32_CKDpub; exposed BIP341 constants

  bigspider

  committed
  7f28011

  Copy full SHA for 7f28011

• Add parsing of Musig2 pubnonces and partial signatures as yielded values in sign_psbt in the python client

  bigspider

  committed
  acc0530

  Copy full SHA for acc0530

Commits on Nov 19, 2024

• MuSig2 signing, rounds 1 and 2

  bigspider

  committed
  3327a8e

  Copy full SHA for 3327a8e

• Update musig() specs, and fix psbt processing

  Show description for 41be6f1
  bigspider

  committed
  41be6f1

  Copy full SHA for 41be6f1

• Fix psbt-level musig signing session logic

  bigspider

  committed
  c15335c

  Copy full SHA for c15335c

• Modularize and extract the musig session handling from sign_psbt.c

  bigspider

  committed
  b0e02d0

  Copy full SHA for b0e02d0

• Persistent storage for musig psbt signing sessions

  bigspider

  committed
  1b3061b

  Copy full SHA for 1b3061b

• Add ragger navigation to musig sign_psbt tests

  bigspider

  committed
  27c95dc

  Copy full SHA for 27c95dc

• Update sanity checks for musig key expressions

  bigspider

  committed
  16261f5

  Copy full SHA for 16261f5

• Add architecture docs for MuSig2

  bigspider

  committed
  5b51ab8

  Copy full SHA for 5b51ab8

• Reference musig docs in musig session module

  bigspider

  committed
  3418b60

  Copy full SHA for 3418b60

• Add const qualifiers, and asserts guarding against overflows

  bigspider

  committed
  8e13101

  Copy full SHA for 8e13101

• Expose new types in python client

  bigspider

  committed
  ad377fb

  Copy full SHA for ad377fb

• Update BIP_MUSIG_CHAINCODE ==> BIP_328_CHAINCODE

  bigspider

  committed
  38a9e80

  Copy full SHA for 38a9e80

• Fix read_change_and_index_from_psbt_bip32_derivation incorrectly aborting prematurely for some PSBTs. Added explanatory comment

  bigspider

  committed
  aea89fd

  Copy full SHA for aea89fd

• Removed unused argument; deleted commented out check

  Show description for 13abab8
  bigspider

  committed
  13abab8

  Copy full SHA for 13abab8

• Generalized count_internal_keys in the test suite to count_internal_key_placeholders, with musig placeholder support

  bigspider

  committed
  5fcdcdf

  Copy full SHA for 5fcdcdf

• Support BIP-389 multipath descriptors in get_descriptor

  bigspider

  committed
  1192d10

  Copy full SHA for 1192d10

• Updated e2e tests to use deterministic xprivs in bitcoin-core

  bigspider

  committed
  6c8fb7e

  Copy full SHA for 6c8fb7e

• Refactor code of is_policy_sane for clarity; improved comments

  bigspider

  committed
  4189823

  Copy full SHA for 4189823

• [WIP] Musig2 e2e tests

  bigspider

  committed
  712bfa7

  Copy full SHA for 712bfa7

• [CI] Use custom image for bitcoin from achow101's branch with MuSig2 support

  bigspider

  committed
  34f2746

  Copy full SHA for 34f2746

• Reduce maximum supported number of keys in musig to 5

  bigspider

  committed
  ce066d7

  Copy full SHA for ce066d7

• Move sign_psbt_cache to global space to reduce stack usage

  bigspider

  committed
  ac4a48c

  Copy full SHA for ac4a48c

• Add array of all internal key expressions in sign_psbt_state_t

  bigspider

  committed
  9645d25

  Copy full SHA for 9645d25

• Refactor input_keys_callback output_keys_callback to match against all the internal key expressions, instead of only the first

  bigspider

  committed
  6184d44

  Copy full SHA for 6184d44

• Added test for incomplete matching of BIP32 derivation paths in policies with multiple internal keys

  bigspider

  committed
  c5a3b92

  Copy full SHA for c5a3b92

• Test that only paths for which a key is present are indeed signed

  bigspider

  committed
  1d25a27

  Copy full SHA for 1d25a27

• Fixup: musig e2e tests

  bigspider

  committed
  6d858b4

  Copy full SHA for 6d858b4

Commits on Nov 20, 2024

• Detect if the PSBT has at least a PSBT_IN_MUSIG2_PUB_NONCE field

  Show description for 3f556d8
  bigspider

  committed
  3f556d8

  Copy full SHA for 3f556d8

Commits on Nov 21, 2024

• Moved MuSig2 Round 1 out of the signing flow. Allow it without user confirmation.

  Show description for b6ce98c
  bigspider

  committed
  b6ce98c

  Copy full SHA for b6ce98c

• Only compute the aggregate key once for each key expression

  bigspider

  committed
  392b942

  Copy full SHA for 392b942

• Fix wrong documentation for get_extended_pubkey; renamed to get_extended_pubkey_from_client

  bigspider

  committed
  752aaa8

  Copy full SHA for 752aaa8

• Refactor most of the MuSig2-related code out of sign_psbt.c

  bigspider

  committed
  e6b07ce

  Copy full SHA for e6b07ce

Commits on Nov 29, 2024

• Use qsort for sorting

  Show description for 568153f
  bigspider

  committed
  568153f

  Copy full SHA for 568153f

• Update protocol documentation for the YIELD client command of sign_psbt

  bigspider

  committed
  715b2be

  Copy full SHA for 715b2be

• Nits and code comment improvements

  bigspider

  committed
  bd286b3

  Copy full SHA for bd286b3

• Add an explicit initializer for the musigsession signing state.

  Show description for b551ed4
  bigspider

  committed
  b551ed4

  Copy full SHA for b551ed4

• Update ragger snapshots for NanoS+ and NanoX

  bigspider

  committed
  4a2a3c5

  Copy full SHA for 4a2a3c5

• Cleanup some tests; remove debug prints

  bigspider

  committed
  08a2ac0

  Copy full SHA for 08a2ac0

Commits on Dec 2, 2024

• Add missing python test dependencies

  bigspider

  committed
  44646bc

  Copy full SHA for 44646bc

• Simplify CI: only e2e tests need a custom image compiled with bitcoin-core

  bigspider

  committed
  5ffb64d

  Copy full SHA for 5ffb64d

• Bump version to 2.4.0-rc; add changelog entry for release 2.4.0

  bigspider

  committed
  f2b0f90

  Copy full SHA for f2b0f90

Commits on Dec 3, 2024

• Add note about nonce reuse in the implementation of compute_rand_i_j

  bigspider

  committed
  6f50e7a

  Copy full SHA for 6f50e7a

Commits on Dec 9, 2024

• Nits from PR review

  bigspider

  committed
  6489700

  Copy full SHA for 6489700

Commits on Dec 10, 2024

• Apply suggestions from code review

  Show description for 2d22ebe
  

  bigspider

  and

  lpascal-ledger

  committed
  2d22ebe

  Copy full SHA for 2d22ebe