Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MuSig2 support #294

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from
Draft

MuSig2 support #294

wants to merge 25 commits into from

Conversation

bigspider
Copy link
Collaborator

@bigspider bigspider commented Oct 9, 2024

Closes: #208

Comment on lines +480 to +485
// int pk_offset = is_tap ? 1 : 0;
// if (memcmp(pubkey.compressed_pubkey + pk_offset, bip32_derivation_pubkey, key_len) != 0)
// {
// return 0;
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.67%. Comparing base (f39ba24) to head (3f00c98).

Files with missing lines Patch % Lines
src/common/wallet.c 83.56% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #294      +/-   ##
===========================================
- Coverage    84.76%   84.67%   -0.10%     
===========================================
  Files           17       17              
  Lines         2186     2231      +45     
===========================================
+ Hits          1853     1889      +36     
- Misses         333      342       +9     
Flag Coverage Δ
unittests 84.67% <84.21%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bigspider bigspider changed the title Musig2 MuSig2 support Oct 9, 2024
…ed some comments.

Generalizing to key expressions containing musig() makes it necessary to distinguish
the key expressions in the wallet policy from the actual key placeholders that are
just indexes to the list of key informations (@num in the descriptor template),
whereas the two concepts were often not clearly separated in the code base.

Renaming to "key expressions" makes the distinction more clear.
…on type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.
 - musig() now sorts the keys, as per the BIP draft
 - correctly compute fingerprint for musig() aggregate key
 - added both the aggregate and the internal key in keyexpr_info_t struct
 - fixed psbt parsing logic to detect change/addr_index for musig
 - updated musig tests
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.0% Coverage on New Code (required ≥ 80%)
11.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MuSig2 support
2 participants