Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KUI-1261): upgrade to KTH Style 10 #373

Merged
19 commits merged into from
Apr 18, 2024
Merged

feat(KUI-1261): upgrade to KTH Style 10 #373

19 commits merged into from
Apr 18, 2024

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2024

Main goal of this PR is to upgrade KTH Style to version 10.

A short summary of what have been done:

  • Upgrading KTH packages and adding new @kth/style along side with old kth-style (the old will be deprecated)
  • General cleanup of DOM structure to algin with other Om kursen apps.
  • New header and footer
  • New of style of all Buttons, Alerts and SideMenu
  • Added "prose" style to articles/text sections
  • General cleanup of style including font-family, colors and more.
  • Move of toolbar url (Personliga menyn) to parameters file to support ref version in ref/loaclhost

Some code are duplicated a cross different Om kursen repos. Such SCSS has been moved to shared.scss and components to /shared-components. PRs for other Om kursen apps that are upgraded at the same time with same structure:

@ghost ghost changed the title kth style 10 feat(KUI-1261): upgrade to KTH Style 10 Apr 15, 2024
@ghost ghost marked this pull request as ready for review April 15, 2024 12:22
@ghost ghost requested a review from belanglos April 16, 2024 07:39
Copy link
Contributor

@belanglos belanglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@belanglos belanglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! I'd like to discuss the archive-page-logic, because I don't understand it :)

@ghost ghost force-pushed the issues/KUI-1261-kth-style branch from f899626 to 88a72d5 Compare April 17, 2024 12:39
@ghost ghost force-pushed the issues/KUI-1261-kth-style branch from 88a72d5 to 4e65047 Compare April 17, 2024 14:49
@ghost ghost merged commit fd38e36 into master Apr 18, 2024
3 checks passed
@ghost ghost mentioned this pull request Jun 14, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants