Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to KTH Style 10
Install dependencies
npm i kth-style@10-latest
npm i @kth/style@latest
npm i @kth/kth-node-web-common@9
Setup environment
CM_HOST_URL
in local.env
to https://www-r-new.referens.sys.kth.se/cm/.Memo page adjustments
main
to wrappingdiv
with classcontainer
. Also added.container.main { @include mixins.container; }
.TODO: Use handlebar helper to render breadcrumbs.
Style organization
table
styles to_table.scss
.@media print
) styles to_print.scss
.Typography
@import "~@kth/style/scss/tokens/typography.scss";
.font-family
inkurs-pn-web.scss
.article { @include prose.prose; }
rule.font-size
:short-text-font-style
is used intable
div
:s andsub-section-header
. It’s aimed to keepfont-size
andline-height
slightly smaller. I removed the styling, but kept the html as is.long-text-font-style
is used forp
andli
incontent-center
. It seems to mostly have played out it’s role and was removed.font-size: 1rem;
frompage-sub-heading-admin-link
and@media width
related related rules for variousp
andli
.h3
ininfo-box
as ah4
with@include font-heading-s
.font-size
for@media print
.TODO: How should we deal with
font-size
forsub-section-header
?Colors
theme: 'student-web'
to allres.render
in controllers.color
,border-color
, andbackground-color
:@include theme-student-web
totable
and.info-box
.$grey: #65656c
is used for table header backgrounds. I replaced it with the darker color$color-gray-dark
.$lightGrey: #f6f6f6
is used astd
background-color
. I replaced it with$color-gray-lighter
.$white: #fff
is used as:color
forth
,tr
, andtd
. Switched it to--color-on-primary
.th
, var(--color-border), andtr
. Switched it to--color-border
.color
forh4
andp
insidetr
. Switched it to--color-on-primary
..info-box
hadbackground-color: #f4f4f4
. Switched it to--color-background-alt
.background-color
for#page-sub-heading-wrapper
.menu-memos
.body
background-color
for@media print
..nav-link.active
with color set toblack
. Changed it to--color-text
.TODO: The side menu needs to be updated after redesign in Cortina.
Spacing