Skip to content

fix(jh): set correct auth when server name is juliahub #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thelonewolf1603 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(jh): set correct auth when server name is juliahub #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd43a98
set correct auth when server name is juliahub
thelonewolf1603 Jan 23, 2026
d6c83cd
juliahub server auth fix
thelonewolf1603 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func readStoredToken() (*StoredToken, error) {

func deviceFlow(server string) (*TokenResponse, error) {
var authServer string
if server == "juliahub.com" {
if server == "juliahub.com" || server == "juliahub.juliahub.com" {
Copy link
Member

@vdayanand vdayanand Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this is a valid domain?

Copy link
Author

@thelonewolf1603 thelonewolf1603 Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if you add a server name e.g. custom , it will be converted to custom.juliahub.com. so if someone types only juliahub that will be converted to juliahub.juliahub.com

authServer = "auth.juliahub.com"
} else {
authServer = server
Expand Down Expand Up @@ -233,7 +233,7 @@ func deviceFlow(server string) (*TokenResponse, error) {

func refreshToken(server string, refreshToken string) (*TokenResponse, error) {
var authServer string
if server == "juliahub.com" {
if server == "juliahub.com" || server == "juliahub.juliahub.com" {
authServer = "auth.juliahub.com"
} else {
authServer = server
Expand Down