Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): build module #833

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

danielroe
Copy link
Contributor

@danielroe danielroe commented Dec 10, 2024

resolves #822

PR Checklist

Overview

seems that the module isn't being built, just stubbed: https://unpkg.com/browse/@konami-emoji-blast/nuxt@0.0.5/dist/module.mjs.

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 9eb9b0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@konami-emoji-blast/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emoji-blast ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:21am

@danielroe
Copy link
Contributor Author

danielroe commented Dec 10, 2024

Not sure exactly how you want things set up (you have three build steps?), but basically the build command now does the 'stubbing' (so you can play with the code without rebuilding). And the build:release creates the final dist files.

I've also pinned TS to v5.6 because of a soon-to-be-fixed issue with vue-tsc + typescript v5.7 (vuejs/language-tools#5018).

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, much appreciated! 🙏

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6167117 into JoshuaKGoldberg:main Dec 10, 2024
11 checks passed
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (94b9afb) to head (9eb9b0f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #833   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe deleted the patch-1 branch December 10, 2024 16:20
@JoshuaKGoldberg
Copy link
Owner

Not sure exactly how you want things set up (you have three build steps?)

Great question. I'm not sure either 🙃. This project hasn't been top-of-mind for me since I got it mostly set up on the monorepo. I'm hoping to eventually finish going through it and getting a good system... but just haven't had the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Cannot start nuxt: Nuxt module should be a function: [object Object]
2 participants