Skip to content

Commit

Permalink
fix(nuxt): build module (#833)
Browse files Browse the repository at this point in the history
resolves #822

## PR Checklist

- [x] Addresses an existing open issue: fixes #000
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/emoji-blast/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [ ] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/emoji-blast/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

seems that the module isn't being built, just stubbed:
https://unpkg.com/browse/@konami-emoji-blast/[email protected]/dist/module.mjs.
  • Loading branch information
JoshuaKGoldberg authored Dec 10, 2024
2 parents 94b9afb + 9eb9b0f commit 6167117
Show file tree
Hide file tree
Showing 3 changed files with 238 additions and 138 deletions.
5 changes: 5 additions & 0 deletions .changeset/mean-ties-decide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@konami-emoji-blast/nuxt": patch
---

We were not building `@konami-emoji-blast/nuxt` - this updates the build step to use `@nuxt/module-builder`.
6 changes: 3 additions & 3 deletions packages/konami-emoji-blast-nuxt/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
],
"scripts": {
"prebuild": "nuxi prepare",
"build": "nuxi build",
"build:release": "nuxt-module-build build --stub && nuxt-module-build prepare && nuxi prepare playground",
"build": "nuxt-module-build build --stub && nuxt-module-build prepare && nuxi prepare playground",
"build:release": "nuxt-module-build build",
"dev": "nuxi dev playground",
"dev:build": "nuxi build playground",
"lint": "eslint .",
Expand All @@ -53,7 +53,7 @@
"@types/node": "^22.1.0",
"eslint": "^9.0.0",
"nuxt": "^3.11.2",
"typescript": "latest",
"typescript": "~5.6",
"vue": "^3.4.37",
"vue-tsc": "^2.0.14"
},
Expand Down
Loading

0 comments on commit 6167117

Please sign in to comment.