Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RingBuffer initialization #273

Conversation

LinjingZhang
Copy link
Collaborator

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
solve the I2S serial port print problem
refer to Arduino Core API: https://github.com/arduino/ArduinoCore-API/tree/master

Related Issue
DESMAKERS-3603

Context
I'm not good at c++ and I'm really not sure why new operator is not working here. It allocate dynamic memory and looks the same to me with or without the change... but the microphone example is not working using new. And also the ArduinoCore is using memset (why?

Copy link
Member

@ederjc ederjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, fine for now - thanks for the fix!
We will refactor this in the future.

Copy link
Member

@OlafFilies OlafFilies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok for me

@ederjc ederjc merged commit bb90666 into Infineon:develop May 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants