Fix fragment shader bindless handle assertion in glfw-gl4 backend #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobLoach
reviewed
Oct 17, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "nuklear", | |||
| "version": "4.10.6", | |||
| "version": "4.10.7", | |||
There was a problem hiding this comment.
Thanks! Since this is part of the demos, likely don't need to bump the version number 👍
Suggested change
| "version": "4.10.7", | |
| "version": "4.10.6", |
RobLoach
reviewed
Oct 17, 2023
| @@ -7,6 +7,7 @@ | |||
| /// - [y]: Minor version with non-breaking API and library changes | |||
| /// - [z]: Patch version with no direct changes to the API | |||
| /// | |||
| /// - 2023/10/11 (4.10.7) - Fix glfw-gl4 assertion faillure | |||
There was a problem hiding this comment.
Suggested change
| /// - 2023/10/11 (4.10.7) - Fix glfw-gl4 assertion faillure |
|
I'm unable to test this. Would someone else be able to give a review? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across #190 while trying to play with the glfw-gl4 backend, some research lead me to the issue and I noticed someone had provided a fix.
Before creating the PR, I had a look at both open and closed PRs to make sure this isn't a duplicate (hopefully I haven't missed a PR with tthese changes)
This PR is meant to introduce the fix @KreideGit gracefuly provided in #190 into the repository.