Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/formulae: add now-mandatory --ignore-dependencies option #1305

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

ZhongRuoyu
Copy link
Member

Since Homebrew/brew#18784 brew uninstall requires the --ignore-dependencies option to be used explicitly.

Fixes failure seen at https://github.com/Homebrew/homebrew-core/actions/runs/11889490048/job/33126293058?pr=198065.

Since Homebrew/brew#18784 `brew uninstall` requires the
`--ignore-dependencies` option to be used explicitly.

Fixes failure seen at https://github.com/Homebrew/homebrew-core/actions/runs/11889490048/job/33126293058?pr=198065.
@ZhongRuoyu ZhongRuoyu merged commit 876d599 into master Nov 18, 2024
7 checks passed
@ZhongRuoyu ZhongRuoyu deleted the brew-uninstall-ignore-dependencies branch November 18, 2024 10:14
ZhongRuoyu added a commit that referenced this pull request Nov 20, 2024
One more (and hopefully last) fix like #1305 and #1306. When we test
dependents of multiple formulae, a dependent of one formula being tested
can happen to be a dependency of another formula being tested. In this
case, we need the `--ignore-dependencies` option to force removal of the
dependent/dependency formula. `brew install --only-dependencies` ensures
that the removed dependent/dependency is reinstalled before its
dependents are tested.

Fixes failure seen at https://github.com/Homebrew/homebrew-core/actions/runs/11923246241/job/33242018653?pr=198240.
ZhongRuoyu added a commit that referenced this pull request Nov 20, 2024
One more (and hopefully last) fix like #1305 and #1306. When we test
dependents of multiple formulae, a dependent of one formula being tested
can happen to be a dependency of another formula being tested. In this
case, we need the `--ignore-dependencies` option to force removal of the
dependent/dependency formula. When testing the dependents of the removed
formula, `brew install --only-dependencies` ensures that it is
reinstalled.

Fixes failure seen at https://github.com/Homebrew/homebrew-core/actions/runs/11923246241/job/33242018653?pr=198240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants