tests/formulae: add missing --ignore-dependencies option
#1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One more fix like #1305. Fixes failure seen at https://github.com/Homebrew/homebrew-core/actions/runs/11889979173/job/33128643880?pr=198048.
daeho-ro
approved these changes
Nov 18, 2024
|
Thanks @ZhongRuoyu! |
ZhongRuoyu
added a commit
that referenced
this pull request
Nov 20, 2024
One more (and hopefully last) fix like #1305 and #1306. When we test dependents of multiple formulae, a dependent of one formula being tested can happen to be a dependency of another formula being tested. In this case, we need the `--ignore-dependencies` option to force removal of the dependent/dependency formula. `brew install --only-dependencies` ensures that the removed dependent/dependency is reinstalled before its dependents are tested. Fixes failure seen at https://github.com/Homebrew/homebrew-core/actions/runs/11923246241/job/33242018653?pr=198240.
ZhongRuoyu
added a commit
that referenced
this pull request
Nov 20, 2024
One more (and hopefully last) fix like #1305 and #1306. When we test dependents of multiple formulae, a dependent of one formula being tested can happen to be a dependency of another formula being tested. In this case, we need the `--ignore-dependencies` option to force removal of the dependent/dependency formula. When testing the dependents of the removed formula, `brew install --only-dependencies` ensures that it is reinstalled. Fixes failure seen at https://github.com/Homebrew/homebrew-core/actions/runs/11923246241/job/33242018653?pr=198240.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more fix like #1305.
Fixes failure seen at https://github.com/Homebrew/homebrew-core/actions/runs/11889979173/job/33128643880?pr=198048.