-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
odrive 7441 #184369
odrive 7441 #184369
Conversation
901f3f5
to
39398b2
Compare
|
39398b2
to
e6cda40
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for flagging this. The livecheck
block URL returns a 405 if HEAD
is used but returns the expected 302 response (with the location
header we want) if GET
is used. The curl exit code is 56 (failure in receiving network data), which is another one that I've been seeing in failing HeaderMatch
checks recently.
I have some stashed work to add 56 to the curl exit codes that #curl_header
will automatically retry with GET
and that will allow this (and a few others) to work for the time being. I'll create a brew PR for it in a bit (edit: Homebrew/brew#18279).
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The related brew PR is merged and this passes CI now 👍
…drive-7441 odrive 7441
Created by
brew bump
Created with
brew bump-cask-pr
.