Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odrive 7441 #184369

Merged
merged 1 commit into from
Sep 10, 2024
Merged

odrive 7441 #184369

merged 1 commit into from
Sep 10, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Sep 5, 2024

Created by brew bump


Created with brew bump-cask-pr.

@chenrui333
Copy link
Member

audit for odrive: failed
 - Version '7441' differs from '' retrieved by livecheck.
 - Version '7441' differs from '' retrieved by livecheck.

@p-linnane
Copy link
Member

curl is returning a 405 error. Paging @samford to see if they have any ideas.

@p-linnane p-linnane added awaiting maintainer feedback Issue needs response from a maintainer. livecheck Issues or PRs related to livecheck labels Sep 6, 2024
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this. The livecheck block URL returns a 405 if HEAD is used but returns the expected 302 response (with the location header we want) if GET is used. The curl exit code is 56 (failure in receiving network data), which is another one that I've been seeing in failing HeaderMatch checks recently.

I have some stashed work to add 56 to the curl exit codes that #curl_header will automatically retry with GET and that will allow this (and a few others) to work for the time being. I'll create a brew PR for it in a bit (edit: Homebrew/brew#18279).

@samford samford removed the awaiting maintainer feedback Issue needs response from a maintainer. label Sep 6, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Sep 10, 2024
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The related brew PR is merged and this passes CI now 👍

@samford samford merged commit 8a1c6bc into master Sep 10, 2024
8 checks passed
@samford samford deleted the bump-odrive-7441 branch September 10, 2024 00:24
github-actions bot pushed a commit to MPLew-is/homebrew-vscodium that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-cask-pr PR was created using `brew bump-cask-pr` livecheck Issues or PRs related to livecheck stale Issue which has not received any feedback for some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants