Curl#curl_headers: Work with 56 exit_status #18279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?I previously added the 8 curl exit code (weird server reply) to the list of non-success exit codes that
#curl_headers
will handle. We're now seeing failures with a 56 exit code (failure in receiving network data), where the server returns a 4xx response for aHEAD
request but the same request usingGET
works as expected (e.g., casks likebeeper
,get-api
,odrive
,ui
, etc.).This adds 56 to the list of exit codes in
#curl_headers
, so a response with a 4xx HTTP status will be automatically retried usingGET
.