Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--model isn't usable #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

--model isn't usable #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
data/
results/
__pycache__
12 changes: 6 additions & 6 deletions start_training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,12 @@ def parse_args(**kwargs):
'scalar': config.scalar,
'discrete_values': config.discrete_values,
}
if config.model is None:
assert config.depth is not None and config.width is not None
model = create_model(config.depth, config.width, **model_kwargs)
else:
model_creator = getattr(f3_models, config.model)
model = model_creator(**model_kwargs)
# if config.model is None:
assert config.depth is not None and config.width is not None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line and instead set the depth and width arguments as required (in lines 61 and 62, see line 80 for an example) as they are now always required.

model = create_model(config.depth, config.width, **model_kwargs)
# else:
# model_creator = getattr(f3_models, config.model)
# model = model_creator(**model_kwargs)
Comment on lines +128 to +133
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the commented out code

print(model)
results = train_model(model, config.dataset, config.device, config.epochs, config.batch_size,
config.test_batch_size, config.lr, config.dry_run, config.log_interval, config.print_eval,
Expand Down