--model isn't usable
#1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluegelk
reviewed
Jun 6, 2024
Comment on lines
+128
to
+133
| # if config.model is None: | ||
| assert config.depth is not None and config.width is not None | ||
| model = create_model(config.depth, config.width, **model_kwargs) | ||
| # else: | ||
| # model_creator = getattr(f3_models, config.model) | ||
| # model = model_creator(**model_kwargs) |
There was a problem hiding this comment.
Please remove the commented out code
| model_creator = getattr(f3_models, config.model) | ||
| model = model_creator(**model_kwargs) | ||
| # if config.model is None: | ||
| assert config.depth is not None and config.width is not None |
There was a problem hiding this comment.
Please remove this line and instead set the depth and width arguments as required (in lines 61 and 62, see line 80 for an example) as they are now always required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--modelarg isn't usable, since it's not even accepted into arglist instart_training.py