Resources + router restructuring #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2780104): https://gunnwatt--pr96-articles-30bh1eez.web.app (expires Wed, 27 Jul 2022 23:26:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
We could also rename the whole thing to |
Yes, I think this is a good idea. |
Also, move resource pages to their own subdirectory of `/components` (from `/components/utilities`)
TODO: consider making a fallback of some sort?
Lazy loading
404 redesign (#97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is from an idea from Michael that WATT should host something similar to https://paly.win/nytimes/.
If we made more tabs for everything then the utilities section would grow even more crowded and annoying to navigate on mobile, so I thought having articles like how to register for a free nytimes subscription would be better on their own path, and have maybe one tab in utilities as a hub that links to all of them. The design of said article pages is up for critique and improvement (it's current heavily inspired by certain pages on my website).
Also, student resources might be good as an article instead of a utilities tab.