Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article pages #98

Closed
ky28059 opened this issue Jul 13, 2022 · 2 comments · Fixed by #96
Closed

Article pages #98

ky28059 opened this issue Jul 13, 2022 · 2 comments · Fixed by #96

Comments

@ky28059
Copy link
Member

ky28059 commented Jul 13, 2022

Formerly, /utilities/articles would link to article pages hosted at /articles/page (top image). I generally like the choice of replacing the pages with modals instead (bottom image) but should the /articles/page pages stick around? A use-case for them would be if someone wants to send a quick link to a specific article they can do so easily by linking gunn.app/articles/..., but if this feature isn't deemed useful then the extra pages would just sit around and increase bundle size.

Thoughts?

image
image
@ky28059 ky28059 linked a pull request Jul 13, 2022 that will close this issue
Resources + router restructuring #96
Merged
@saumyasinghal747
Copy link
Contributor

I think they should be pages on mobile but modals on desktop to take advantage of the large screen space.

@ky28059 ky28059 mentioned this issue Jul 13, 2022
Closed
@icedTet
Copy link
Contributor

icedTet commented Jul 13, 2022

Regarding bundle sizes, can't you just use React.lazy for those pages specifically?

@ky28059 ky28059 mentioned this issue Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resources + router restructuring GunnWATT/watt
3 participants
@ky28059 @saumyasinghal747 @icedTet