Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting simple CI #7

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Setting simple CI #7

merged 6 commits into from
Dec 12, 2023

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Dec 11, 2023

No description provided.

@Hartorn Hartorn requested a review from rabah-khalek December 11, 2023 23:54
@Hartorn Hartorn self-assigned this Dec 11, 2023
Copy link

linear bot commented Dec 11, 2023

GSK-2366 Setting up CI

mainly for pytest at this point

@Hartorn Hartorn marked this pull request as ready for review December 11, 2023 23:59
uses: pdm-project/setup-pdm@v3
with:
python-version: ${{ matrix.python-version }}
cache: false # Removing cache, as it's not worth for now (around 3min to restore + time to save vs 3 min to clean install)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍

run: pdm install -G :all

- name: Ensure opencv contrib is working
run: pdm run pip install --force-reinstall opencv-contrib-python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? just curious

Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@rabah-khalek rabah-khalek merged commit c92941c into main Dec 12, 2023
1 of 3 checks passed
@rabah-khalek rabah-khalek deleted the feature/gsk-2366-setting-up-ci branch December 12, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants