Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get basic image metadata from image properties #49

Merged
merged 32 commits into from
Aug 12, 2024
Merged

Get basic image metadata from image properties #49

merged 32 commits into from
Aug 12, 2024

Conversation

Inokinoki
Copy link
Member

@Inokinoki Inokinoki commented Aug 2, 2024 •
edited
Loading

Generate meta data from images.

@Inokinoki Inokinoki marked this pull request as ready for review August 5, 2024 16:53
@Inokinoki Inokinoki requested a review from rabah-khalek August 6, 2024 12:29
@Inokinoki
Copy link
Member Author

Should we add them automatically in any datasets?

@Inokinoki Inokinoki mentioned this pull request Aug 6, 2024
Merged
rabah-khalek
rabah-khalek suggested changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good, let's just promot meta_auto to the default get_meta method

giskard_vision/core/detectors/base.py Outdated Show resolved Hide resolved
giskard_vision/core/dataloaders/base.py Outdated Show resolved Hide resolved
giskard_vision/core/dataloaders/hf.py Show resolved Hide resolved
@Inokinoki Inokinoki requested a review from rabah-khalek August 9, 2024 10:47
rabah-khalek
rabah-khalek approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's just change the issue group of the default meta

@Inokinoki Inokinoki enabled auto-merge (squash) August 12, 2024 16:32
@Inokinoki Inokinoki disabled auto-merge August 12, 2024 16:45
@Inokinoki Inokinoki merged commit 677cf94 into main Aug 12, 2024
5 checks passed
@Inokinoki Inokinoki deleted the basic-internal-metadata branch August 12, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabah-khalek rabah-khalek rabah-khalek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Inokinoki @rabah-khalek