Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object detection #43

Merged
merged 36 commits into from
Aug 7, 2024
Merged

Object detection #43

merged 36 commits into from
Aug 7, 2024

Conversation

rabah-khalek
Copy link
Contributor

@rabah-khalek rabah-khalek commented Jul 22, 2024 •
edited
Loading

Support for object detection models/datasets

@rabah-khalek rabah-khalek marked this pull request as draft July 25, 2024 12:29
rabah-khalek and others added 21 commits July 25, 2024 14:33
@rabah-khalek
docstrings
0793709
@rabah-khalek
updated types
41d178a
@rabah-khalek
Merge branch 'main' into object-detection
d7e9060
@rabah-khalek
update pyproject
45b410a
@rabah-khalek
degraded version of torch
1c2f684
@rabah-khalek
merge
d1f6b54
@bmalezieux
Merge branch 'main' into object-detection
95079ac
@bmalezieux
ENH: scan for object detection
0ff93f9
@rabah-khalek
added demo
f305cd6
@bmalezieux
Merge remote-tracking branch 'origin/racoon-detection-demo' into obje…
3603c55 
…ct-detection-scan
@bmalezieux
UPD: making it work for racoons data
61f4eea
@rabah-khalek
added clipping
b6e9703
@bmalezieux
FIX: cap x_min and y_min to 0 in surrogates + raise errors by default…
f2f6034 
… in internal scan
@rabah-khalek
Merge pull request #48 from Giskard-AI/racoon-detection-demo
1763b8d 
Racoon detection demo
@rabah-khalek
Merge branch 'main' into object-detection
538d149
@rabah-khalek
Merge branch 'object-detection' into object-detection-scan
218c8cc
@rabah-khalek
updated packages
86a934f
@rabah-khalek
fixing clipping method
d512867
@rabah-khalek
fixing racoon loader, adding example images for notebook
80adfe7
@rabah-khalek
adding trained model to avoid training in CI
d862676
@rabah-khalek
small cleanup: notebooks
9bc76da
@rabah-khalek rabah-khalek marked this pull request as ready for review August 5, 2024 08:49
@rabah-khalek rabah-khalek requested a review from Inokinoki August 5, 2024 08:49
Inokinoki
Inokinoki reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the files are reviewed in Benoit's branch, except the racoon model.
LGTM at the moment

examples/object_detection/racoon_detection/.DS_Store Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the .DS_Store.

examples/object_detection/racoon_detection/Racoon Images/images/raccoon-84.jpg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these images cherry-picked to have only one raccoon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

giskard_vision/object_detection/models/wrappers.py Outdated
return self.detector(imgs)


class FasterRCNNBase(ModelBase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Inokinoki
Inokinoki reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

giskard_vision/core/dataloaders/base.py
from ..types import TypesBase

EthicalIssueMeta = IssueGroup(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also moved them somewhere in #49

Let's merge your PR first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@rabah-khalek rabah-khalek merged commit 453f277 into main Aug 7, 2024
3 of 5 checks passed
@rabah-khalek rabah-khalek deleted the object-detection branch August 7, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inokinoki Inokinoki Inokinoki left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabah-khalek @Inokinoki @bmalezieux