Allow user to create floating view panels #4521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
example screenshot
without the floating, the vertical stack is large
|
|
note that it is entirely optional to float a panel, and can be done one view at a time |
cmdcolin
force-pushed
the
floating_view_panel
branch
from
78b0a5c to
65ed1eb
Compare
cmdcolin
changed the title
cmdcolin
force-pushed
the
floating_view_panel
branch
3 times, most recently
from
e33530e to
812f548
Compare
cmdcolin
force-pushed
the
floating_view_panel
branch
2 times, most recently
from
5c24e1d to
a2e5b66
Compare
cmdcolin
force-pushed
the
floating_view_panel
branch
from
a2e5b66 to
4ee443f
Compare
cmdcolin
force-pushed
the
floating_view_panel
branch
2 times, most recently
from
fd41e5d to
73dd391
Compare
Back with main
cmdcolin
force-pushed
the
floating_view_panel
branch
from
73dd391 to
3a4c2dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to make view panels "float" in a draggable dialog. This idea was sketched out a little while ago but trying it out again because it could solve real problems allowing more stuff to be accomodated on a screen (solve the "screen is too tall" effect)
There could potentially be situations where there is z-index fighting due to assumptions in this PR but we could try to standardize the z-index "numering" more to try to help with this
This PR proposes the floating view at 100, which allows menu bars and tooltips to go over it. It goes under the track selector currently
The alternative to this floating system is like a tiling window manager, or a masonry layout https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_grid_layout/Masonry_layout but these are hard (and, not mutually exclusive with this approach here)