-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: override rules #945
base: develop
Are you sure you want to change the base?
feat: override rules #945
Conversation
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
lint & Test Build, Post Setup pnpm cache, |
What is this supposed to mean? |
A small attempt to help someone who knows how to resolve the merge conflict. I don't have much of an idea. |
2973c67
to
6361222
Compare
For anyone willing to test this, it's available with the preview tag: |
@gauthier-th I just pulled this image and am doing some testing. For some reason when I try to add an override rule to either sonarr or radarr, I'm not able to create the rule. When I click on 'Creat Rule' nothing happens, and I don't see anything (either errors or anything at all) either the jellyseer log or the docker logs. Here is the rule I'm trying to create for sonarr: |
78f9233
to
a8bd51f
Compare
I just rebased the PR to the latest commit of develop, can you please test again with this version? (you'll need to update the Docker image) If it's still not working, could you check Jellyseerr logs as well as your browser logs and see if there is anything there? (F12 -> Console) |
I have tried it but nothing happens when I press the |
That means your migrations didn't apply. Can you test with a fresh config first? |
I have tried again with a fresh configuration and the same thing happens. I have searched for the override_rule table in db.sqlite3 and it does not appear. |
I just tried testing this as well, and can't get the override screen to appear. Here's how I set it up, in case I did something wrong:
My Radarr edit screen looks like this: The About page shows I'm on develop: Ran the following to confirm my working environment:
|
It's not in develop branch. It's in |
Thank you! Got the preview image running, and I get 404 errors in the browser log trying to save the override rule (and on a recurring basis simply while on that screen).
Edit: Using the local API page, I get the same error as @juancarlosromerogarcia:
|
Oops, I may have forgotten to write the migration. I'll write them and it should work better 😅 |
@starlingfire the migration script has been added. Can you please test again? (you'll need to update the Docker image) |
@gauthier-th so far, so good. I added an override rule to put a user's downloads in a different root folder, and it appears to be working. I'll mess around with it more tomorrow when I get a bit more time. I'm so excited to have this feature! |
Just tested on my system and it seems to be working as well. Thanks for this! |
I have tested both sonarr and radarr with various rules that assign root folders depending on the user. It works without problems. |
I hope this gets merged. It will certainly help me set up Radarr Anime instances easily |
Would this allow routing to multiple *arr instances simultaneously? Really looking forward to this being merged! |
No, this will not change the behavior of the *arr instances, just change which parameters are passed to the instance when a media is requested. |
This will let you route media to different root folders based on who made the request, so each user can add to their own individual library. But you can do that within the same instance of the arr stack, you don't need multiple. |
Yeah, I figured. Eventually hoping for something like this to become native functionality in a *seerr |
3c8fb4f
to
aade72b
Compare
Description
This PR introduces override rules in Jellyseerr.
Override rules are used to define conditions for each service (i.e. for each Radarr/Sonarr server) on which parameters will be modified.
For example, it's possible to define a different quality profile for certain users, or change the root path according to the genre of a film or series, etc.
Screenshot (if UI-related)
To-Dos
pnpm build
pnpm i18n:extract
Issues Fixed or Closed