Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quality profile per user #757

Closed

Conversation

gauthier-th
Copy link
Collaborator

@gauthier-th gauthier-th commented May 20, 2024

Description

This PR adds options to define specific quality profiles per user. The quality profile sent to Radarr/Sonarr will be changed if the setting has been modified for the user making the request.

Screenshot (if UI-related)

Default values in the user settings, taken from the service option (4k option for Radarr/Sonarr also exists but is not showed here):
image

With a different quality profile for Radarr:
image

In the next request of the user, the quality profile on Radarr will be Bluray 1080p (unless the person that accepts the media request chooses another profile).

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Fixes

@gauthier-th gauthier-th requested a review from Fallenbagel as a code owner May 20, 2024 17:44
@feerlessleadr
Copy link

@gauthier-th really excited to see this PR. Does this also include the ability to set root folders per user as well?

@gauthier-th
Copy link
Collaborator Author

@gauthier-th really excited to see this PR. Does this also include the ability to set root folders per user as well?

Not for now, this only includes the quality profiles per user.
It may be something we add on our roadmap @Fallenbagel? I don't know how much this is needed or asked.

@Fallenbagel
Copy link
Owner

Not for now, this only includes the quality profiles per user.
It may be something we add on our roadmap @Fallenbagel? I don't know how much this is needed or asked.

It's already in the road map. This pr accomplishes part of it. Then the rootfolder should accomplish a small part and the overriding rootfolder/profile depending on filter rules the rest

@gauthier-th gauthier-th linked an issue Jun 4, 2024 that may be closed by this pull request
1 task
Copy link

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Jun 23, 2024
@gauthier-th gauthier-th marked this pull request as draft July 22, 2024 16:09
@gauthier-th gauthier-th linked an issue Aug 7, 2024 that may be closed by this pull request
1 task
@gauthier-th gauthier-th linked an issue Aug 19, 2024 that may be closed by this pull request
1 task
@gauthier-th
Copy link
Collaborator Author

This is closed in favor of #945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Cannot merge due to merge conflicts
Projects
None yet
3 participants